From: Andy Wingo <wingo@pobox.com>
To: Mark H Weaver <mhw@netris.org>
Cc: "Ludovic Courtès" <ludo@gnu.org>, guile-devel@gnu.org
Subject: Re: [PATCH] Add private port structure, and move iconv descriptors there
Date: Mon, 01 Apr 2013 21:04:37 +0200 [thread overview]
Message-ID: <87bo9ydqd6.fsf@pobox.com> (raw)
In-Reply-To: <8738vb5p7x.fsf@tines.lan> (Mark H. Weaver's message of "Sun, 31 Mar 2013 15:44:18 -0400")
On Sun 31 Mar 2013 21:44, Mark H Weaver <mhw@netris.org> writes:
> + {
> + GC_finalization_proc prev_finalizer;
> + GC_PTR prev_finalization_data;
> +
> + /* Register a finalizer to close the descriptors. */
> + GC_REGISTER_FINALIZER_NO_ORDER (id, finalize_iconv_descriptors, 0,
> + &prev_finalizer, &prev_finalization_data);
> + }
Here we really want 6978c673393a960d7caf604b8c72ff2b5fe0f4ec; committed
as 75ba64d6797f5857cc9885eb753126119a8c8b68 in stable-2.0, but probably
needs to be manually reapplied here.
Otherwise looks great to me.
--
http://wingolog.org/
prev parent reply other threads:[~2013-04-01 19:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 11:39 always O_BINARY? Andy Wingo
2013-02-24 12:08 ` Neil Jerram
2013-02-24 16:55 ` Mike Gran
2013-02-24 21:17 ` Ludovic Courtès
2013-02-28 3:24 ` Adding new information to scm_t_port (was Re: always O_BINARY?) Mark H Weaver
2013-02-28 8:53 ` Andy Wingo
2013-02-28 11:04 ` Ludovic Courtès
2013-02-28 13:09 ` Andy Wingo
2013-03-01 9:03 ` Ludovic Courtès
2013-03-05 18:55 ` Mark H Weaver
2013-03-27 20:00 ` [PATCH] Add private port structure, and move iconv descriptors there Mark H Weaver
2013-03-27 20:28 ` Ludovic Courtès
2013-03-27 20:51 ` Andy Wingo
2013-03-27 21:11 ` Mark H Weaver
2013-03-31 7:52 ` [PATCH] Add internal-only port structure; " Mark H Weaver
2013-03-31 13:20 ` Ludovic Courtès
2013-03-31 15:23 ` Mark H Weaver
2013-03-31 22:06 ` Ludovic Courtès
2013-04-01 18:57 ` Andy Wingo
2013-04-01 20:03 ` Mark H Weaver
2013-04-01 20:54 ` Andy Wingo
2013-04-01 21:04 ` Andy Wingo
2013-03-31 19:44 ` [PATCH] Add private port structure, and " Mark H Weaver
2013-03-31 22:08 ` Ludovic Courtès
2013-04-01 19:04 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo9ydqd6.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).