unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: segfault in guile 1.6.7
Date: Sat, 26 Mar 2005 07:37:08 +1100	[thread overview]
Message-ID: <87acorea2z.fsf@zip.com.au> (raw)
In-Reply-To: <20050324171151.GA2647@voins.local> (Alexey Voinov's message of "Thu, 24 Mar 2005 20:11:52 +0300")

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Alexey Voinov <voins@voins.program.ru> writes:
>
> guile> (string-index (string (integer->char 209)) char-numeric?)
> zsh: 2760 segmentation fault  guile

Thanks.

> I haven't checked if this bug is still present in cvs HEAD.

Marius made a change that squashes it.

> Patch attached.

I'll bring across what's in the head, which is to have SCM_MAKE_CHAR
cast to an unsigned char, instead of demanding that from all callers.


[-- Attachment #2: chars.h.unsigned.diff --]
[-- Type: text/plain, Size: 406 bytes --]

--- chars.h.~1.11.4.4.~	2004-04-25 09:25:32.000000000 +1000
+++ chars.h	2005-03-26 07:36:06.574079280 +1100
@@ -51,7 +51,7 @@
  */
 #define SCM_CHARP(x) (SCM_ITAG8(x) == scm_tc8_char)
 #define SCM_CHAR(x) ((unsigned int)SCM_ITAG8_DATA(x))
-#define SCM_MAKE_CHAR(x) SCM_MAKE_ITAG8((scm_t_bits) x, scm_tc8_char)
+#define SCM_MAKE_CHAR(x) SCM_MAKE_ITAG8((scm_t_bits) (unsigned char) (x), scm_tc8_char)
 
 \f
 

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel

  reply	other threads:[~2005-03-25 20:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-24 17:11 segfault in guile 1.6.7 Alexey Voinov
2005-03-25 20:37 ` Kevin Ryde [this message]
2005-03-25 20:47   ` Kevin Ryde
2005-05-22 18:59 ` Marius Vollmer
2005-05-23  1:34   ` Kevin Ryde
2005-06-06 19:20     ` Marius Vollmer
2005-06-06 22:07       ` Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87acorea2z.fsf@zip.com.au \
    --to=user42@zip.com.au \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).