unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH]: Critical section checked for incorrect thread.
Date: Sun, 14 Dec 2008 00:59:49 +0100	[thread overview]
Message-ID: <87abaz39u2.fsf@gnu.org> (raw)
In-Reply-To: 3ae3aa420812131539v7eb5e53dp65cb12d2dc67cc18@mail.gmail.com

Hi Linas,

"Linas Vepstas" <linasvepstas@gmail.com> writes:

> --- guile-1.8.6.orig/libguile/throw.c  2008-12-08 11:42:56.000000000 -0600
> +++ guile-1.8.6/libguile/throw.c 2008-12-13 17:28:27.000000000 -0600
> @@ -692,7 +692,7 @@ scm_ithrow (SCM key, SCM args, int noret
>    SCM dynpair = SCM_UNDEFINED;
>    SCM winds;
>
> -  if (scm_i_critical_section_level)
> +  if (SCM_I_CURRENT_THREAD->block_asyncs)
>      {
>        fprintf (stderr, "throw from within critical section.\n");
>        abort ();

It seems to me that "throw from within critical section" means precisely
"throw when SCM_I_CRITICAL_SECTION_LEVEL is non-zero".  I don't see what
asyncs have to do with that.

Thanks,
Ludo'.





  reply	other threads:[~2008-12-13 23:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-13 23:39 [PATCH]: Critical section checked for incorrect thread Linas Vepstas
2008-12-13 23:59 ` Ludovic Courtès [this message]
2008-12-16 22:21   ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87abaz39u2.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).