From: Neil Jerram <neil@ossau.uklinux.net>
To: linasvepstas@gmail.com
Cc: Guile Development <guile-devel@gnu.org>
Subject: Re: Locks and threads
Date: Wed, 25 Mar 2009 19:00:04 +0000 [thread overview]
Message-ID: <87ab79sa17.fsf@arudy.ossau.uklinux.net> (raw)
In-Reply-To: <87mybzvipu.fsf@arudy.ossau.uklinux.net> (Neil Jerram's message of "Thu\, 05 Mar 2009 20\:05\:17 +0000")
Neil Jerram <neil@ossau.uklinux.net> writes:
>> Yes, it's an unrelated bug. All of the places that raise errors (and
>> so exit non-locally) should exit the critical section first.
>
>> You're absolutely right. I'll leave this part out, and generate a
>> separate patch for it.
>
> Here's the separate patch...
> Subject: [PATCH] Avoid throw from critical section, given invalid sigaction call
>
> * libguile/scmsigs.c (scm_sigaction_for_thread): Exit critical section
> before raising out-of-range error.
>
> * test-suite/Makefile.am (SCM_TESTS): Add signals.test.
>
> * test-suite/tests/signals.test: New file.
I've committed this now too. (Also to 1.8.x. I'll come back later to
look at which of all these lock fixes are needed in master.)
Neil
next prev parent reply other threads:[~2009-03-25 19:00 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 22:31 Locks and threads Neil Jerram
2009-02-11 23:05 ` Neil Jerram
2009-02-11 23:32 ` Ludovic Courtès
2009-02-11 23:30 ` Linas Vepstas
2009-02-11 23:53 ` Neil Jerram
2009-02-12 0:18 ` Linas Vepstas
2009-02-12 20:51 ` Ludovic Courtès
2009-02-11 23:30 ` Ludovic Courtès
2009-02-12 12:55 ` Greg Troxel
2009-02-12 18:00 ` Ken Raeburn
2009-02-12 21:14 ` Ludovic Courtès
2009-02-14 1:25 ` Ken Raeburn
2009-02-14 16:09 ` Ludovic Courtès
2009-03-05 20:41 ` Neil Jerram
2009-03-04 23:49 ` Neil Jerram
2009-03-05 3:54 ` Linas Vepstas
2009-03-05 19:46 ` Neil Jerram
2009-03-05 20:05 ` Neil Jerram
2009-03-05 20:40 ` Linas Vepstas
2009-03-05 20:49 ` Neil Jerram
2009-03-05 20:57 ` Linas Vepstas
2009-03-05 21:25 ` Neil Jerram
2009-03-05 21:56 ` Linas Vepstas
2009-03-06 11:01 ` Andy Wingo
2009-03-06 12:36 ` Linas Vepstas
2009-03-06 22:05 ` Ludovic Courtès
2009-03-08 22:04 ` Neil Jerram
2009-03-25 19:00 ` Neil Jerram [this message]
2009-03-25 22:08 ` Ludovic Courtès
2009-03-05 21:35 ` Ludovic Courtès
2009-03-10 23:57 ` Neil Jerram
2009-03-12 0:07 ` Neil Jerram
2009-03-12 0:53 ` Neil Jerram
2009-03-12 1:29 ` Linas Vepstas
2009-03-12 3:09 ` Clinton Ebadi
2009-03-25 22:13 ` Neil Jerram
2009-03-25 22:34 ` Linas Vepstas
2009-03-12 22:13 ` Andy Wingo
2009-03-13 19:13 ` Neil Jerram
2009-03-25 23:19 ` Neil Jerram
2009-03-26 3:40 ` Linas Vepstas
2009-03-26 8:02 ` Neil Jerram
2009-03-26 18:39 ` Linas Vepstas
2009-03-26 9:10 ` Ludovic Courtès
2009-03-26 22:01 ` Neil Jerram
2009-03-26 23:12 ` Ludovic Courtès
2009-03-26 22:51 ` Neil Jerram
2009-03-27 3:15 ` Linas Vepstas
2009-03-14 14:23 ` Ludovic Courtès
2009-03-16 22:57 ` Andy Wingo
2009-03-25 18:57 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ab79sa17.fsf@arudy.ossau.uklinux.net \
--to=neil@ossau.uklinux.net \
--cc=guile-devel@gnu.org \
--cc=linasvepstas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).