From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: "no duplicate" in `popen.test' Date: Wed, 20 May 2009 13:39:13 +0200 Message-ID: <87ab58gg0u.fsf@gnu.org> References: <87wso5livc.fsf@gnu.org> <87od9dc657.fsf@ossau.uklinux.net> <877idqlloh.fsf@gnu.org> <49dd78620806091348o55eab7cag2acf60218357b251@mail.gmail.com> <87tz3g3awf.fsf@arudy.ossau.uklinux.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1242819577 3242 80.91.229.12 (20 May 2009 11:39:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 May 2009 11:39:37 +0000 (UTC) Cc: guile-devel@gnu.org To: Neil Jerram Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed May 20 13:39:30 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M6k8v-0001hF-5O for guile-devel@m.gmane.org; Wed, 20 May 2009 13:39:29 +0200 Original-Received: from localhost ([127.0.0.1]:36494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6k8u-0002CU-KM for guile-devel@m.gmane.org; Wed, 20 May 2009 07:39:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6k8o-0002CF-3b for guile-devel@gnu.org; Wed, 20 May 2009 07:39:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6k8i-0002C0-HM for guile-devel@gnu.org; Wed, 20 May 2009 07:39:21 -0400 Original-Received: from [199.232.76.173] (port=58224 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6k8i-0002Bx-EE for guile-devel@gnu.org; Wed, 20 May 2009 07:39:16 -0400 Original-Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:14438) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M6k8h-00049d-VB for guile-devel@gnu.org; Wed, 20 May 2009 07:39:16 -0400 X-IronPort-AV: E=Sophos;i="4.41,221,1241388000"; d="scan'208";a="40283444" Original-Received: from unknown (HELO nixey) ([194.199.1.33]) by mail4-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 20 May 2009 13:39:13 +0200 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 1 Prairial an 217 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i686-pc-linux-gnu In-Reply-To: <87tz3g3awf.fsf@arudy.ossau.uklinux.net> (Neil Jerram's message of "Wed, 20 May 2009 00:56:00 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8491 Archived-At: Hi Neil, Neil Jerram writes: > I finally got back to this. I'm pretty sure the attached patch is now > correct, so will commit in a couple of days unless anyone objects. Thanks for working on it! Please go ahead. > * test-suite/tests/popen.test (open-input-pipe:no duplicate): Add > another pipe from parent to child, so that the child can finish by > reading from this. Then the parent controls the child lifetime by > writing to this pipe. > > test-suite/tests/popen.test (open-output-pipe:no duplicate): Add > another pipe from child to parent, and have the child finish by > endlessly writing into this. Then the parent controls the child > lifetime by closing its end of the pipe, causing a broken pipe in > the child. One nitpick: this entry doesn't completely follow the GNU ChangeLog style. Also, the rationale for the change belongs in comments in `popen.test' rather than in the commit log. Thanks, Ludo'.