[PATCH] Fix warning about extra semicolon in guile-snarf output

[PATCH] Fix warning about extra semicolon in guile-snarf output

[Julian Graham]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hey Guilers,

Long time no see!  I was porting some code I wrote to use
`guile-snarf' for doing gsubr binding, and I noticed that if you've
got -pedantic and -Wall turned on, GCC complains that the code
generated by snarfing has an extra semicolon:

  "ISO C does not allow extra ; outside of a function"

The attached patch fixes that issue by removing a semicolon from the
expansion of `SCM_STATIC_SUBR_OBJVECT'.  Anyone mind if I apply it?


Regards,
Julian

[-- Attachment #2: 0001-Remove-extraneous-semicolon-from-SCM_STATIC_SUBR_OBJ.patch --]
[-- Type: text/x-diff, Size: 1059 bytes --]

From 7cd2bf271d2063cdc3bd2827f7dc5fd9e928b446 Mon Sep 17 00:00:00 2001
From: Julian Graham <julian@navigator.(none)>
Date: Sun, 18 Sep 2011 16:58:47 -0400
Subject: [PATCH] Remove extraneous semicolon from `SCM_STATIC_SUBR_OBJVECT' to prevent ISO
 C90 warning.

* snarf.h (SCM_STATIC_SUBR_OBJVECT): Remove semicolon at end of macro
  definition.
---
 libguile/snarf.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libguile/snarf.h b/libguile/snarf.h
index b0800c4..1c072ba 100644
--- a/libguile/snarf.h
+++ b/libguile/snarf.h
@@ -372,7 +372,7 @@ SCM_SNARF_INIT(scm_set_smob_apply((tag), (c_name), (req), (opt), (rest));)
     SCM_PACK (0),                                                       \
     foreign,                                                            \
     SCM_BOOL_F, /* the name */                                          \
-  };									\
+  }
 
 #define SCM_STATIC_PROGRAM(c_name, objcode, objtable, freevars)         \
   static SCM_ALIGNED (8) SCM_UNUSED SCM                                 \
-- 
1.7.4.1

Re: [PATCH] Fix warning about extra semicolon in guile-snarf output

[Ludovic Courtès]

Hi Julian!

Julian Graham <joolean@gmail.com> skribis:

> The attached patch fixes that issue by removing a semicolon from the
> expansion of `SCM_STATIC_SUBR_OBJVECT'.  Anyone mind if I apply it?

Applied, thanks!

Ludo’.