From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.2-100-g40bd6a7 Date: Wed, 21 Sep 2011 11:13:30 +0200 Message-ID: <87aa9y2r7p.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1316596427 8571 80.91.229.12 (21 Sep 2011 09:13:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2011 09:13:47 +0000 (UTC) Cc: guile-devel@gnu.org To: "Andy Wingo" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 21 11:13:41 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Is8-0002T0-R2 for guile-devel@m.gmane.org; Wed, 21 Sep 2011 11:13:40 +0200 Original-Received: from localhost ([::1]:53925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Is7-0004hE-Nv for guile-devel@m.gmane.org; Wed, 21 Sep 2011 05:13:39 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:51212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Is1-0004gI-Q7 for guile-devel@gnu.org; Wed, 21 Sep 2011 05:13:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6Is0-0008Hl-9P for guile-devel@gnu.org; Wed, 21 Sep 2011 05:13:33 -0400 Original-Received: from solo.fdn.fr ([80.67.169.19]:38054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Is0-0008Hf-5A for guile-devel@gnu.org; Wed, 21 Sep 2011 05:13:32 -0400 Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) (Authenticated sender: lcourtes) by smtp.fdn.fr (Postfix) with ESMTPSA id 3D90D445C0; Wed, 21 Sep 2011 11:13:31 +0200 (CEST) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Jour des =?iso-8859-1?Q?R=E9compenses?= de =?iso-8859-1?Q?l'Ann=E9e?= 219 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: (Andy Wingo's message of "Wed, 21 Sep 2011 07:00:53 +0000") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 80.67.169.19 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:12770 Archived-At: Hi Andy, Thanks for polishing peval! "Andy Wingo" skribis: > commit 4f33b47591e823500d800ee4f9d98c8ae98ceab8 > Author: Andy Wingo > Date: Wed Sep 21 08:58:09 2011 +0200 > > peval: inlining of let-values >=20=20=20=20=20 > * module/language/tree-il/optimize.scm (peval): Add support for > let-values. Try to inline the consumer into the body of the produc= er, > if there is only one return point, and we can figure out how many > values are being returned, and that number is compatible with the > consumer. > > commit 65a32655253cdfcf4e2caf03a73ac66b05da5f71 > Author: Andy Wingo > Date: Wed Sep 21 08:56:09 2011 +0200 > > peval support for more forms >=20=20=20=20=20 > * module/language/tree-il/optimize.scm (peval): Add support for fix, > dynwind, dynlet, dynref, module-set, and toplevel-set. (Mutating a > variable directly is similar to calling a function that does so beh= ind > our backs, so this presents no additional problem.) I believe that at least the and cases are dead code since =E2=80=98fix-letrec!=E2=80=99 hasn=E2=80=99t been called at the point= =E2=80=98peval=E2=80=99 is called. No? Also, could you add tests for the new cases handled? :-) It=E2=80=99d mak= e it easier for me to follow, and would help us not break it later. Thanks, Ludo=E2=80=99.