From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: Unexpected srfi-4 C Interface Change in 2.0.10 Date: Wed, 19 Mar 2014 14:12:27 -0400 Message-ID: <87a9cmqcqc.fsf@yeeloong.lan> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1395252792 17980 80.91.229.3 (19 Mar 2014 18:13:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Mar 2014 18:13:12 +0000 (UTC) Cc: guile-devel@gnu.org To: Daniel Llorens Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Mar 19 19:13:21 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQKzP-0004aW-H5 for guile-devel@m.gmane.org; Wed, 19 Mar 2014 19:13:19 +0100 Original-Received: from localhost ([::1]:43042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQKzP-0005fF-1P for guile-devel@m.gmane.org; Wed, 19 Mar 2014 14:13:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQKzI-0005dj-Vt for guile-devel@gnu.org; Wed, 19 Mar 2014 14:13:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQKzE-0004be-9y for guile-devel@gnu.org; Wed, 19 Mar 2014 14:13:12 -0400 Original-Received: from world.peace.net ([96.39.62.75]:54176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQKzE-0004aj-51 for guile-devel@gnu.org; Wed, 19 Mar 2014 14:13:08 -0400 Original-Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=yeeloong.lan) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WQKz5-00079u-7n; Wed, 19 Mar 2014 14:12:59 -0400 In-Reply-To: (Daniel Llorens's message of "Wed, 19 Mar 2014 18:04:39 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 96.39.62.75 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16987 Archived-At: Daniel Llorens writes: >> Message: 2 >> Date: Wed, 19 Mar 2014 10:22:40 -0400 >> From: Barry Fishman >> To: guile-devel@gnu.org >> Subject: Unexpected srfi-4 C Interface Change in 2.0.10 >> Message-ID: >> Content-Type: text/plain >> >> When building C interface code using scm_f32vector_writable_elements() >> in 2.0.10 and on the trunk I found: >> >> For a vector generated in guile with: >> >> (f32vector 0.25 0.25 0.25 1.0) >> >> I found in the C interface: >> >> scm_t_array_handle handle; >> size_t vlen, vinc; >> float *arrayp; >> >> arrayp = scm_f32vector_writable_elements(s_uvec, &handle, >> &vlen, &vinc) >> >> When I test vlen it now seems to contain the number of bytes (16) >> rather than the number of elements (4) in the f32vector. >> >> It was 4 in 2.0.9 and the guile trunk I built on Jan 8. >> It was 16 in 2.0.10 and the guile trunk I built on March 17. >> I assume it relates to the Feb 8 changes, where: >> (in commit dc65b88d839c326889618112c4870ad3a64e9446) >> >> *lenp = scm_c_bytevector_length (uvec) / width; >> >> and width is set to 1 in the macro: >> >> DEFINE_SRFI_4_C_FUNCS (F32, f32, float, 1); > > This is a bug. Is there a test setup for the C interface? > > The last argument of DEFINE_SRFI_4_C_FUNCS (1) is correct; that can be 1 or 2, because complex types use a pointer to real. We could use C99 complex types and get rid of it. Just cast the pointer for C<99 users (?) > > The bug appeared in replacing the deprecated scm_uniform_vector_elements() with the bytevector functions. Generally lengths are computed with scm_i_array_element_type_sizes[] in uniform.c (e.g. see make_bytevector() in bytevector.c). > > So the patch would be > > *lenp = scm_c_bytevector_length (uvec) / (width * scm_i_array_element_type_sizes[ETYPE (TAG)]) ; > > Actually I'd do > > *lenp = scm_c_bytevector_length (uvec) / (width * sizeof(ctype)) This last one looks good to me. The length check 4 lines above this also needs to be fixed: if (!scm_is_bytevector (uvec) \ || (scm_c_bytevector_length (uvec) % (width * sizeof(ctype)))) \ scm_wrong_type_arg_msg (NULL, 0, uvec, #tag "vector"); \ I guess it's time to release 2.0.11 :-/ Mark