From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christopher Allan Webber Newsgroups: gmane.lisp.guile.devel Subject: Re: Elisp branch ready for merge (??) Date: Fri, 11 Mar 2016 08:30:33 -0800 Message-ID: <87a8m50yfq.fsf@dustycloud.org> References: <87egbo0zxc.fsf@dustycloud.org> <87d1r71rag.fsf@dustycloud.org> <8760wz14q9.fsf@dustycloud.org> <87io0yppbn.fsf@gnu.org> <87y49uyxhb.fsf@dustycloud.org> <87d1r1235o.fsf@dustycloud.org> <87wpp95f80.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457714596 12439 80.91.229.3 (11 Mar 2016 16:43:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2016 16:43:16 +0000 (UTC) Cc: guile-devel To: Mathieu Lirzin Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Mar 11 17:43:08 2016 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aeQ9O-0004C5-DF for guile-devel@m.gmane.org; Fri, 11 Mar 2016 17:42:54 +0100 Original-Received: from localhost ([::1]:56306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aePxi-0003Ap-D5 for guile-devel@m.gmane.org; Fri, 11 Mar 2016 11:30:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aePxY-0003Ad-2P for guile-devel@gnu.org; Fri, 11 Mar 2016 11:30:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aePxT-0002nF-Vx for guile-devel@gnu.org; Fri, 11 Mar 2016 11:30:40 -0500 Original-Received: from dustycloud.org ([50.116.34.160]:37772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aePxT-0002nB-Qo; Fri, 11 Mar 2016 11:30:35 -0500 Original-Received: from oolong (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 2A55126728; Fri, 11 Mar 2016 11:30:34 -0500 (EST) User-agent: mu4e 0.9.13; emacs 24.5.1 In-reply-to: <87wpp95f80.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 50.116.34.160 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:18216 Archived-At: Mathieu Lirzin writes: > Christopher Allan Webber writes: > >> Well, I didn't think I'd have time to do this (and in a sense I didn't) >> but: >> https://gitlab.com/dustyweb/guile/tree/merge-bipt-elisp-wip >> >> I've rebased the whole branch against git master and added ChangeLog >> style entries. "make check" is passing. It seems to me that it's ready >> for merge. I did the best I could on the ChangeLog additions, both with >> my limited ChangeLog experience and from my limited Guile internals >> experience. So, corrections welcome, but otherwise... > > Nice! > > Small nitpick. Could you remove the extra spaces at the start of > indented lines? :) > > I know this practice is/was a common practice in Guile but even if it > looks prettier with indentation, this is not the proper change log > format described by GCS and recognized by 'change-log-mode' in Emacs. I could... but I'm hesitant to do so if it's not the standard ways to do things in Guile's repository. I'll leave that question to whoever is interested in merging it. If they'd like me to change it, I'll do it, and since they have commit access, I consider them the authority.