From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Marius Vollmer Newsgroups: gmane.lisp.guile.devel Subject: Re: srfi-19 date-week-number gremlin Date: Sun, 05 Oct 2003 17:24:53 +0200 Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: <878ynz6722.fsf@zagadka.ping.de> References: <87ekzq1ksf.fsf@zip.com.au> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1065367642 465 80.91.224.253 (5 Oct 2003 15:27:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 5 Oct 2003 15:27:22 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Oct 05 17:27:20 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1A6An2-0008Hh-00 for ; Sun, 05 Oct 2003 17:27:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1A6AlM-0001Vx-GR for guile-devel@m.gmane.org; Sun, 05 Oct 2003 11:25:36 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1A6AlJ-0001Un-3Q for guile-devel@gnu.org; Sun, 05 Oct 2003 11:25:33 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1A6Akm-0001BA-3O for guile-devel@gnu.org; Sun, 05 Oct 2003 11:25:32 -0400 Original-Received: from [195.253.8.218] (helo=mail.dokom.net) by monty-python.gnu.org with esmtp (Exim 4.24) id 1A6Akl-0001AX-Mp for guile-devel@gnu.org; Sun, 05 Oct 2003 11:24:59 -0400 Original-Received: from dialin.speedway42.dip88.dokom.de ([195.138.42.88] helo=zagadka.ping.de) by mail.dokom.net with smtp (Exim 3.36 #3) id 1A6Aml-0007Ry-00 for guile-devel@gnu.org; Sun, 05 Oct 2003 17:27:03 +0200 Original-Received: (qmail 26176 invoked by uid 1000); 5 Oct 2003 15:24:53 -0000 Original-To: guile-devel@gnu.org In-Reply-To: <87ekzq1ksf.fsf@zip.com.au> (Kevin Ryde's message of "Wed, 13 Aug 2003 10:08:32 +1000") User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Developers list for Guile, the GNU extensibility library List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:2846 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:2846 Kevin Ryde writes: > I noticed srfi-19 date-week-number seems to be off by 1 in its week > start calculation. For instance looking at Jan 1984, Sat 7th should > be in the first week and Sun 8th begin the next, but alas, > > (date-week-number (make-date 0 0 0 0 7 1 1984 0) 0) > (date-week-number (make-date 0 0 0 0 8 1 1984 0) 0) > > both give 1. > > The code looks about right, just doesn't take into account > date-year-day starting from 1 rather than 0. > > * srfi-19.scm (date-week-number): Correction, day of week starting > week was off by one. > > * tests/srfi-19.test (date-week-number): Add tests. > > I think this could go in the 1.6 branch too. Yes, please. -- GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405 _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel