From: Marius Vollmer <mvo@zagadka.de>
Subject: Re: srfi-19 date-week-number gremlin
Date: Sun, 05 Oct 2003 17:24:53 +0200 [thread overview]
Message-ID: <878ynz6722.fsf@zagadka.ping.de> (raw)
In-Reply-To: <87ekzq1ksf.fsf@zip.com.au> (Kevin Ryde's message of "Wed, 13 Aug 2003 10:08:32 +1000")
Kevin Ryde <user42@zip.com.au> writes:
> I noticed srfi-19 date-week-number seems to be off by 1 in its week
> start calculation. For instance looking at Jan 1984, Sat 7th should
> be in the first week and Sun 8th begin the next, but alas,
>
> (date-week-number (make-date 0 0 0 0 7 1 1984 0) 0)
> (date-week-number (make-date 0 0 0 0 8 1 1984 0) 0)
>
> both give 1.
>
> The code looks about right, just doesn't take into account
> date-year-day starting from 1 rather than 0.
>
> * srfi-19.scm (date-week-number): Correction, day of week starting
> week was off by one.
>
> * tests/srfi-19.test (date-week-number): Add tests.
>
> I think this could go in the 1.6 branch too.
Yes, please.
--
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2003-10-05 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-13 0:08 srfi-19 date-week-number gremlin Kevin Ryde
2003-10-05 15:24 ` Marius Vollmer [this message]
2003-10-06 23:23 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ynz6722.fsf@zagadka.ping.de \
--to=mvo@zagadka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).