From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: GUILE_MAX_HEAP_SIZE Date: Mon, 18 Aug 2008 17:34:31 +0200 Message-ID: <878wuus5fc.fsf@gnu.org> References: <87ej4tmf4m.fsf@gnu.org> <87d4k7e0s8.fsf@gnu.org> <87hc9iwyxi.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1219073714 13018 80.91.229.12 (18 Aug 2008 15:35:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Aug 2008 15:35:14 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Aug 18 17:36:06 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KV6lz-0006TX-Cx for guile-devel@m.gmane.org; Mon, 18 Aug 2008 17:35:59 +0200 Original-Received: from localhost ([127.0.0.1]:46198 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KV6l2-0005ry-CB for guile-devel@m.gmane.org; Mon, 18 Aug 2008 11:35:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KV6kw-0005qv-JN for guile-devel@gnu.org; Mon, 18 Aug 2008 11:34:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KV6kv-0005pm-Q4 for guile-devel@gnu.org; Mon, 18 Aug 2008 11:34:54 -0400 Original-Received: from [199.232.76.173] (port=44710 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KV6kv-0005pZ-Ma for guile-devel@gnu.org; Mon, 18 Aug 2008 11:34:53 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:51106 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KV6ku-0001iX-Et for guile-devel@gnu.org; Mon, 18 Aug 2008 11:34:53 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KV6kj-0005ag-4K for guile-devel@gnu.org; Mon, 18 Aug 2008 15:34:41 +0000 Original-Received: from 193.50.110.219 ([193.50.110.219]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Aug 2008 15:34:41 +0000 Original-Received: from ludo by 193.50.110.219 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Aug 2008 15:34:41 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 69 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 193.50.110.219 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Fructidor an 216 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i686-pc-linux-gnu User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) Cancel-Lock: sha1:Y6m2bb8LeNSEK9KhmTtSuA26NXA= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7455 Archived-At: Hi Han-Wen, Han-Wen Nienhuys writes: > Ludovic Courtès escreveu: >> is kind of hard to review in a glimpse. Does it just randomly "clean >> things up" (whatever that means---it does not follow the GCS, for > > GCS? "GNU Coding Standards", the thing we're supposed to adhere to when writing code for the GNU Project: http://www.gnu.org/prep/standards/ >> instance), or does it fix anything? It's hard to tell. Can you >> reproduce the heap usage graphs referred earlier in this thread? Do > > No, the memory usage is more stable now. Can you show what the graph looks like, for comparison purposes? >> you have any evidence of improved behavior? Is it this patch that >> triggers the assertion failure you referred to in your first message? >> Which assertion is it that fails? > > This is fixed now. See my message about our test-suite being broken > by LD_LIBRARY_PATH. Which assertion is it that failed? Was that due to an old `libguile-i18n.so' being loaded? > I had a look at pulling this change apart, but it is tricky since > many of the changes are interrelated. That's also why it's tricky to review. > I spent more than a day writing and debugging this code - approximately > 16 hours over the weekend. Please keep in mind that I write serious > software for a living during my 40 hour work week, and don't much time > for GUILE to spare. Well, I suppose most of us are in this situation, as you probably know. That doesn't mean we never make mistakes, nor that peer review is useless. > If you think you need to roll back this change, please revoke my > commit privilege and sort things out yourself. I tried and failed, and so did Kevin (http://thread.gmane.org/gmane.lisp.guile.devel/6699/focus=6832). AIUI, both Kevin and I tried to identify the root of the problem (the "bug") in a way that would allow us to fix the offending code as conservatively as possible. Conversely, the size and scope of your patch leaves me the impression that you rewrote parts of the GC, without actually pinpointing what was/is wrong with the code. I'd have been much more confident with a one-liner along with an explanation and sample program to determine whether the problem is there. > The garbage collector isn't that complicated after all. Then the people, including me, who spent large amounts of time trying in vain to fix the code must have been dumb. Thanks, Ludovic.