From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Rottmann Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] R6RS-style block comments Date: Mon, 05 Oct 2009 23:52:25 +0200 Message-ID: <878wfppkyu.fsf@delenn.lan> References: <87hbx0sb35.fsf@delenn.lan> <87tyyi6t6c.fsf@gnu.org> <877hvaq8gf.fsf@delenn.lan> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1254779581 9880 80.91.229.12 (5 Oct 2009 21:53:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Oct 2009 21:53:01 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Oct 05 23:52:51 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MuvU9-0003rZ-Iu for guile-devel@m.gmane.org; Mon, 05 Oct 2009 23:52:49 +0200 Original-Received: from localhost ([127.0.0.1]:38624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MuvU9-0004jA-3R for guile-devel@m.gmane.org; Mon, 05 Oct 2009 17:52:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MuvU6-0004j5-PE for guile-devel@gnu.org; Mon, 05 Oct 2009 17:52:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MuvU2-0004io-AR for guile-devel@gnu.org; Mon, 05 Oct 2009 17:52:46 -0400 Original-Received: from [199.232.76.173] (port=39723 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MuvU2-0004il-7p for guile-devel@gnu.org; Mon, 05 Oct 2009 17:52:42 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]:41375) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1MuvU1-0008AG-Fo for guile-devel@gnu.org; Mon, 05 Oct 2009 17:52:41 -0400 Original-Received: (qmail invoked by alias); 05 Oct 2009 21:52:39 -0000 Original-Received: from 83-215-154-5.hage.dyn.salzburg-online.at (EHLO nathot.lan) [83.215.154.5] by mail.gmx.net (mp053) with SMTP; 05 Oct 2009 23:52:39 +0200 X-Authenticated: #3102804 X-Provags-ID: V01U2FsdGVkX1//4YIN8jP/wSlGef+g/3iW/VmRKSH+P+HqF2FeqQ IS1g8RqGoPzgjK Original-Received: by nathot.lan (Postfix, from userid 121) id 3A0C93A688; Mon, 5 Oct 2009 23:52:39 +0200 (CEST) Original-Received: from delenn.lan (delenn.lan [192.168.1.11]) by nathot.lan (Postfix) with ESMTP id B687D3A672; Mon, 5 Oct 2009 23:52:27 +0200 (CEST) Original-Received: by delenn.lan (Postfix, from userid 1000) id 6035C74EB0; Mon, 5 Oct 2009 23:52:25 +0200 (CEST) In-Reply-To: <877hvaq8gf.fsf@delenn.lan> (Andreas Rottmann's message of "Mon, 05 Oct 2009 15:25:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.67 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9445 Archived-At: Andreas Rottmann writes: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Hi, >> >> Andreas Rottmann writes: >> >>> Attached is a patch that extends the read syntax to allow for #| ... |# >>> block comments. >> >> Are there objections to this patch? If no, I=E2=80=99ll apply it. >> >> Note that it makes the reader understand this syntax by default, not via >> a read option. >> > I have attached an updated version of the patch which should apply > cleanly against current HEAD. > I just noticed that the patch breaks "reader.test", as that hardcodes the message exception message format string (eeew!) -- if you apply that patch, you might want to change that string as well. Regards, Rotty --=20 Andreas Rottmann --