unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: Nala Ginrut <nalaginrut@gmail.com>
Cc: guile-devel@gnu.org
Subject: Re: [FEATURE] List all available languages
Date: Fri, 25 Jan 2013 12:06:21 +0100	[thread overview]
Message-ID: <878v7hcyj6.fsf@pobox.com> (raw)
In-Reply-To: <1359110632.3676.30.camel@Renee-desktop.suse> (Nala Ginrut's message of "Fri, 25 Jan 2013 18:43:52 +0800")

On Fri 25 Jan 2013 11:43, Nala Ginrut <nalaginrut@gmail.com> writes:

> @@ -33,6 +33,9 @@
>  
>  (define-module (ice-9 command-line)
>    #:autoload (system vm vm) (set-default-vm-engine! set-vm-engine! the-vm)
> +  #:use-module (srfi srfi-1)
> +  #:use-module (ice-9 regex)
> +  #:use-module (ice-9 ftw)
>    #:export (compile-shell-switches
>              version-etc
>              *GPLv3+*

For the reason given in the comment above this block, we cannot load
these modules at startup.  (Too expensive.)  I suggest you make a little
trampoline that does a module-ref at runtime like eval-string/lang.

> +(define (not-inner-lang? str)
> +  (not (string-match 
> +	"glil|glil\\.scm|assembly|assembly\\.scm|bytecode|objcode\\.scm|objcode|tree-il|tree-il\\.scm|value|\\.\\.|\\." 
> +	str)))
> +
> +(define (get-all-available-languages)
> +  (let lp((rest (map (lambda (x) (string-append x "/language")) %load-path)) (result '()))
> +    (cond
> +     ((null? rest) (apply lset-union string=? result))
> +     (else 
> +      (let ((ll (scandir (car rest) not-inner-lang?)))
> +	(lp (cdr rest) (if ll (cons ll result) result)))))))

This is pretty nasty :)  First of all I would request that you have no
tabs please and stick to the 80-char limit.  But more substantially I
would want a function that returns a list of symbols and calls
lookup-language on them, recursively filtering out any language that is
the target of another compiler.

> +           ((string=? "--list-languages" arg) ; list all languages
> +            (for-each (lambda (l)
> +                        (format #t "~a~%" l))
> +                      (get-all-available-languages))
> +            (exit 0))
> +

Also this needs to respect the 80-character width, somehow.

> +(define (valid-lang? str)
> +  (not (string-match 
> +	"[A-Za-z0-9_ -]+\\.scm|\\.\\.|\\." 
> +	str)))
> +
> +(define (get-all-available-languages)
> +  (let lp((rest (map (lambda (x) (string-append x "/language")) %load-path)) (result '()))
> +    (cond
> +     ((null? rest) (apply lset-union string=? result))
> +     (else 
> +      (let ((ll (scandir (car rest) valid-lang?)))
> +	(lp (cdr rest) (if ll (cons ll result) result)))))))
> +

Why is this duplicated here?

> +  -l, --list-languages list all available languages

Probably we don't need the short option.

Regards,

Andy
-- 
http://wingolog.org/



  reply	other threads:[~2013-01-25 11:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 11:28 [FEATURE] List all available languages Nala Ginrut
2013-01-25  9:56 ` Nala Ginrut
2013-01-25 10:43   ` Nala Ginrut
2013-01-25 11:06     ` Andy Wingo [this message]
2013-01-25 16:46       ` Nala Ginrut
2013-01-31 10:32         ` Andy Wingo
2013-02-01  2:34           ` Nala Ginrut
2013-01-25 20:06       ` Mark H Weaver
2013-01-25 22:50         ` Mark H Weaver
2013-01-26  1:44           ` Nala Ginrut
2013-01-27 10:21           ` Andy Wingo
2013-01-27 15:31             ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v7hcyj6.fsf@pobox.com \
    --to=wingo@pobox.com \
    --cc=guile-devel@gnu.org \
    --cc=nalaginrut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).