Re: native Win32 guile 1.7.0

[Kevin Ryde <user42@zip.com.au>]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

stefan <stefan@lkcc.org> writes:
>
> I just added a check for unsetenv() in the configure script and used it in
> posix.c appropiately for mingw32 hosts.  Which means that a
> putenv("name="); would remove the environment variable 'name'.

I think there's a small memory leak there, viz

	(while #t (putenv "FOO"))

Perhaps

        * posix.c (s_scm_putenv): Free temporary ptr in mingw unset.

Of course the main putenv bit also leaks, but that's another story :-).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: posix.c.mingw-putenv.diff --]
[-- Type: text/x-patch, Size: 498 bytes --]

--- posix.c.~1.114.~	2003-05-31 09:42:53.000000000 +1000
+++ posix.c	2003-06-08 17:57:04.000000000 +1000
@@ -1157,7 +1157,7 @@
 	    "The return value is unspecified.")
 #define FUNC_NAME s_scm_putenv
 {
-  int rv;
+  int rv, e;
   char *ptr;
 
   SCM_VALIDATE_STRING (1, str);
@@ -1177,6 +1177,7 @@
       ptr[SCM_STRING_LENGTH (str)] = '=';
       ptr[SCM_STRING_LENGTH (str) + 1] = 0;
       rv = putenv (ptr);
+      e = errno; free (ptr); errno = e;
       if (rv < 0)
 	SCM_SYSERROR;
 #endif

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel