From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: port-for-each vs lazy sweep Date: Sun, 26 Aug 2007 19:36:44 +0200 Message-ID: <877ini6vv7.fsf@chbouib.org> References: <878x88pbcc.fsf@zip.com.au> <46D0AB14.3030508@xs4all.nl> <8764328bxq.fsf@chbouib.org> <46D1B562.5030104@xs4all.nl> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1188149970 25746 80.91.229.12 (26 Aug 2007 17:39:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 26 Aug 2007 17:39:30 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Aug 26 19:39:28 2007 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IPM58-0008CR-JD for guile-devel@m.gmane.org; Sun, 26 Aug 2007 19:39:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPM58-00013W-2d for guile-devel@m.gmane.org; Sun, 26 Aug 2007 13:39:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IPM3M-0008Dn-8W for guile-devel@gnu.org; Sun, 26 Aug 2007 13:37:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IPM3L-0008Cw-Cb for guile-devel@gnu.org; Sun, 26 Aug 2007 13:37:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPM3L-0008Cg-5E for guile-devel@gnu.org; Sun, 26 Aug 2007 13:37:35 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IPM3K-000403-JW for guile-devel@gnu.org; Sun, 26 Aug 2007 13:37:34 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IPM39-0004cG-6u for guile-devel@gnu.org; Sun, 26 Aug 2007 19:37:23 +0200 Original-Received: from adh419.fdn.fr ([80.67.176.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 26 Aug 2007 19:37:23 +0200 Original-Received: from ludo by adh419.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 26 Aug 2007 19:37:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 46 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: adh419.fdn.fr X-URL: http://www.laas.fr/~lcourtes/ X-PGP-Key-ID: 0xEB1F5364 X-PGP-Key: http://www.laas.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i486-pc-linux-gnu User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) Cancel-Lock: sha1:KSugRv+PC+bNuk+5nAwt5VbLi0U= X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:6757 Archived-At: Hi, Han-Wen Nienhuys writes: > Ludovic Courtès escreveu: >>> @@ -472,6 +480,7 @@ scm_i_init_guile (SCM_STACKITEM *base) >>> scm_init_backtrace (); /* Requires fluids */ >>> scm_init_fports (); >>> scm_init_strports (); >>> + scm_init_ports (); >>> scm_init_gdbint (); /* Requires strports */ >>> scm_init_hash (); >>> scm_init_hashtab (); >>> @@ -490,7 +499,6 @@ scm_i_init_guile (SCM_STACKITEM *base) >>> scm_init_numbers (); >>> scm_init_options (); >>> scm_init_pairs (); >>> - scm_init_ports (); >> >> Why does it need to be moved? > > because gdb instantiates a port; I forgot why it used to work > though. You mean `gdbint.c', right? Anyway, it would be better as a separate patch. >>> - SCM_SETPTAB_ENTRY (port, pt); >>> + SCM_SETPTAB_ENTRY(port, pt); >> >> Please follow GNU style. > > I have the impression that GUILE isn't really consistent That's not a valid excuse. :-) In addition, the above diff excerpt is altering well-formatted code for no reason. > time for a grand search & replace patch? I don't think it'd be a good idea. Let's just try to be consistent with new code that goes in. Thanks, Ludovic. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel