From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-1-17-g77332b2 Date: Fri, 31 Jul 2009 14:32:16 +0200 Message-ID: <877hxpvxrj.fsf@gnu.org> References: <87hbwtaien.fsf@gnu.org> <1249005535.12325.5054.camel@localhost.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1249043557 6282 80.91.229.12 (31 Jul 2009 12:32:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Jul 2009 12:32:37 +0000 (UTC) Cc: Guile Devel To: Mike Gran Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Jul 31 14:32:30 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MWrHg-0001vT-VD for guile-devel@m.gmane.org; Fri, 31 Jul 2009 14:32:29 +0200 Original-Received: from localhost ([127.0.0.1]:36932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWrHg-0000XZ-4h for guile-devel@m.gmane.org; Fri, 31 Jul 2009 08:32:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWrHc-0000Sc-Dh for guile-devel@gnu.org; Fri, 31 Jul 2009 08:32:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWrHX-0000Kj-4j for guile-devel@gnu.org; Fri, 31 Jul 2009 08:32:23 -0400 Original-Received: from [199.232.76.173] (port=55839 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWrHX-0000KZ-1B for guile-devel@gnu.org; Fri, 31 Jul 2009 08:32:19 -0400 Original-Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:27293) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MWrHW-0006UB-Dv for guile-devel@gnu.org; Fri, 31 Jul 2009 08:32:18 -0400 X-IronPort-AV: E=Sophos;i="4.43,302,1246831200"; d="scan'208";a="33881969" Original-Received: from laptop-147-210-128-170.labri.fr (HELO nixey) ([147.210.128.170]) by mail1-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 31 Jul 2009 14:32:16 +0200 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Thermidor an 217 de la =?iso-8859-1?Q?R=E9volutio?= =?iso-8859-1?Q?n?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <1249005535.12325.5054.camel@localhost.localdomain> (Mike Gran's message of "Thu, 30 Jul 2009 18:58:55 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9005 Archived-At: Hi Mike, Mike Gran writes: > On Fri, 2009-07-31 at 00:57 +0200, Ludovic Court=E8s wrote: > Hello! >>=20 >> "Michael Gran" writes: >>=20 >> > The branch, master has been updated >> > via 77332b21a01fac906ae4707426e00f01e62c0415 (commit) >> > from e5dc27b86d0eaa470f92cdaa9f4ed2a961338c49 (commit) >>=20 >> Oops, I hadn't realized this was in `master'. Was it intended? (I >> don't remember seeing a discussion, but I may have skipped it.) >>=20 > > It was discussed after a fashion. This is a precursor to the tree > that Andy reviewed, and he seemed to be okay with me committing some of > it.[1] With all the exciting stuff going on, I was having a little > trouble getting some mindshare. [2] [3] So I pushed this one since > it was kind of your idea anyway. [4] Oh right, thanks for reminding me! And sorry for having been unresponsive lately (too much good work going on and too little spare time!). >> Does it have a user-visible effect? > > No change at all in the character names it will accept. A minor > change on the output: writing U+0012 now gives #\ff over #\np. > Certainly the removal of EBCDIC would be a user-visible effect if > there were an EBCDIC user.=20 Right, it probably won't hurt many people, so that's OK. Nevertheless, it's probably better to mention it in `NEWS', what do you think? >> > * libguile/print.c (iprin1): use new func scm_i_charname >> >=20=20=20=20=20 >> > * libguile/read.c (scm_read_character): use new func >> > scm_i_charname_to_num >> >=20=20=20=20=20 >> > * libguile/chars.c (scm_i_charname): new function >> > (scm_i_charname_to_char): new function >> > (scm_charnames, scm_charnums): removed >>=20 >> These removals are incompatible in theory, but probably they don't >> warrant a `NEWS' entry. Thoughts? > > If they were API, they weren't well documented as such. They look like > internal information to me. Definitely. It's just that they lacked the `_i_' prefix, which in theory means that it's public and that we won't change it without notice. Let's assume removing these two is harmless. Thanks, Ludo'.