unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] Support for SRFI 27
Date: Sun, 15 Aug 2010 16:57:13 +0200	[thread overview]
Message-ID: <877hjrudo6.fsf@gnu.org> (raw)
In-Reply-To: 87eie1w5nv.fsf@delenn.lan

Hello!

Andreas Rottmann <a.rottmann@gmx.at> writes:

> Attached is my take on adding SRFI 27 "Sources of Random Bits".

Nice!  Looks good to me.  Could you also add a node to
doc/ref/srfi-modules.texi?

> +;; These tests are commented out since it /could/ happen that
> +;; `random-source-randomize!' (or `random-source-pseudo-randomize!') puts the
> +;; RNG into a state where it generates the same number as before. If you run
> +;; them manually, they should have a very high chance of passing, though.

Perhaps you could run them anyway and throw 'unresolved when they appear
to fail?  The guardian tests do that when it’s impossible to determine
whether it’s a failure or whether some unrelated phenomenon prevented
the test to pass.

Thanks,
Ludo’.




  reply	other threads:[~2010-08-15 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14 15:55 [PATCH] Support for SRFI 27 Andreas Rottmann
2010-08-15 14:57 ` Ludovic Courtès [this message]
2010-08-28 17:15   ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hjrudo6.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).