unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: Trouble joining with threads from C
Date: Wed, 13 Apr 2011 23:34:29 +0200	[thread overview]
Message-ID: <877haxzvh6.fsf@gnu.org> (raw)
In-Reply-To: 87ipuhzvvk.fsf@gnu.org

Hello,

ludo@gnu.org (Ludovic Courtès) writes:

> ludo@gnu.org (Ludovic Courtès) writes:
>> Andy Wingo <wingo@pobox.com> writes:
>>
>>> No, the issue is elsewhere, that the thread-exit handlers were not being
>>> called
>>
>> I just tried with 60582b7c2a495957012f9a20cd8691dc6307a850 and
>> ‘on_thread_exit’ /is/ called after something like
>> ‘(call-with-new-thread (lambda () #t))’.
>
> The thread-exit handlers were not being called *for threads launched by
> scm_spawn_thread*.
>
> The patch below (against 60582b7c2a495957012f9a20cd8691dc6307a850) fixes it.

After reviewing f60a7648d5926555c7760364a6fbb7dc0cf60720 (which
addressed the same issue), I lean towards reverting it and instead
applying the patch I just sent.

The problem I see with f60a7648d5926555c7760364a6fbb7dc0cf60720 is that
it re-introduces a pthread_key, even when using TLS, and make things a
bit complex IMO.

Thoughts?

Besides, reverting it may fix --without-threads builds.

Thanks,
Ludo’.




  reply	other threads:[~2011-04-13 21:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07  5:56 Trouble joining with threads from C Mark H Weaver
2011-03-09  6:48 ` Mark H Weaver
2011-03-18 12:23   ` Andy Wingo
2011-03-20 23:11     ` Ludovic Courtès
2011-04-13 21:25       ` Ludovic Courtès
2011-04-13 21:34         ` Ludovic Courtès [this message]
2011-04-15  8:41           ` Andy Wingo
2011-04-15 21:44             ` Ludovic Courtès
2011-04-16 15:55               ` Andy Wingo
2011-04-25 13:53             ` Ludovic Courtès
2011-04-25 14:19               ` Andy Wingo
2011-04-25 14:49                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877haxzvh6.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).