From: Mark H Weaver <mhw@netris.org>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: Problem with removing <config.h> from gen-scmconfig when cross-compiling
Date: Thu, 13 Mar 2014 11:16:26 -0400 [thread overview]
Message-ID: <877g7y6sdx.fsf@yeeloong.lan> (raw)
In-Reply-To: <87fvmmxlro.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 13 Mar 2014 14:37:15 +0100")
ludo@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver <mhw@netris.org> skribis:
>
>> Commit 8cb0d6d7fa9aaac316c29a64c541336b51b6f93d "build: Don't include
>> <config.h> in native programs when cross-compiling." apparently broke
>> cross-compiling. Madsy on #guile, who successfully cross-compiled
>> e1bb79f for mingw, ran into this problem with 21a7ba9:
>>
>> make[1]: Entering directory `/home/madsy/mingw/home/madsy/test/guile-2.0.9.f239-21a7b-dirty/libguile'
>> GEN gen-scmconfig.o
>> gen-scmconfig.c: In function 'main':
>> gen-scmconfig.c:245:39: error: 'SIZEOF_CHAR' undeclared (first use in this function)
>> gen-scmconfig.c:245:39: note: each undeclared identifier is reported only once for each function it appears in
>
> Arrgggh, indeed, sorry!
>
> We should revert that patch, but then I’m not sure how to properly fix
> the initial problem, which is that gen-scmconfig.c ends up using
> Gnulib’s <stdio.h> etc.
Madsy told me that the only problem he had when cross-compiling e1bb79f
was in c-tokenize.c. He worked around it by simply removing "#include
<config.h>" from that file. gen-scmconfig.c was not a problem.
The specific problem was that c-tokenize.c includes <stdlib.h>,
but gen-scmconfig.c doesn't include <stdlib.h>.
I agree that this is fragile and should be reworked somehow, but for
2.0.10, I wonder if we could just revert the part of 8cb0d6d having to
do with gen-scmconfig.c.
What do you think?
> Could Madsy check, after reverting the patch, if it works when doing
> things in this order:
>
> /* Include the “real” headers. */
> #include <stdio.h>
> #include <stdlib.h>
>
> /* Get the useful definitions. */
> #include <config.h>
My impression is that we can't rely on this level of help from Madsy, at
least not in the short term.
Didn't hydra.nixos.org do MinGW cross-builds of Guile in the past?
If so, what happened to those?
Mark
next prev parent reply other threads:[~2014-03-13 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 1:23 Problem with removing <config.h> from gen-scmconfig when cross-compiling Mark H Weaver
2014-03-13 13:37 ` Ludovic Courtès
2014-03-13 15:16 ` Mark H Weaver [this message]
2014-03-13 15:47 ` Ludovic Courtès
2014-03-13 16:37 ` Mark H Weaver
2014-03-13 18:05 ` Ludovic Courtès
2014-03-14 21:43 ` Mark H Weaver
2014-03-17 6:48 ` Doug Evans
2014-03-17 20:32 ` Ludovic Courtès
2014-03-18 1:45 ` Doug Evans
2014-03-13 17:00 ` Mark H Weaver
2014-03-13 18:23 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g7y6sdx.fsf@yeeloong.lan \
--to=mhw@netris.org \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).