From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Rottmann Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add SRFI-25 implementation Date: Sat, 14 Nov 2015 16:33:49 +0100 Message-ID: <877flkvbmq.fsf@delenn.home.rotty.xx.vu> References: <1438034381-18809-1-git-send-email-a.rottmann@gmx.at> <87y4ekgzz6.fsf@gnu.org> <87ziysdxbk.fsf@gnu.org> <87y4e1u930.fsf@netris.org> <871tbt38pb.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1447560615 5862 80.91.229.3 (15 Nov 2015 04:10:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Nov 2015 04:10:15 +0000 (UTC) Cc: Andy Wingo , Mark H Weaver , guile-devel To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Nov 15 05:10:04 2015 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zxodf-0007gA-Gq for guile-devel@m.gmane.org; Sun, 15 Nov 2015 05:10:03 +0100 Original-Received: from localhost ([::1]:39707 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxode-0003Vb-EX for guile-devel@m.gmane.org; Sat, 14 Nov 2015 23:10:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxcqZ-0001yf-Eq for guile-devel@gnu.org; Sat, 14 Nov 2015 10:34:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxcqW-00014j-Nk for guile-devel@gnu.org; Sat, 14 Nov 2015 10:34:35 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:49241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxcqW-00013x-Dc; Sat, 14 Nov 2015 10:34:32 -0500 Original-Received: from delenn.home.rotty.xx.vu ([85.127.106.102]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LbMF8-1ahSJZ2Ahe-00kvzc; Sat, 14 Nov 2015 16:33:51 +0100 Original-Received: by delenn.home.rotty.xx.vu (Postfix, from userid 1000) id 1448032005E; Sat, 14 Nov 2015 16:33:49 +0100 (CET) In-Reply-To: <871tbt38pb.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 13 Nov 2015 22:12:16 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Provags-ID: V03:K0:+Mg2o42g811M7z+3jH6Gvcl+dnlN4uKugQgSdhzl4inxWYs3fDw WovvtCaU30tFKh8cMPlr1kxuFQJk3ZtpWGyc5k9dcIIx4pBtdyFV7ecm98qcEONItX9QIIJ 6q4+1WmidKs+cTzJEwl/ELxMdNvpxgdu6cHP2OZt9gtuzwqAZLndQTpWH6W8WwEm0Cv46Ak wXHeH0FiqumCc4BWfGUag== X-UI-Out-Filterresults: notjunk:1;V01:K0:jvd1GV7v3F0=:egdzE/H9pxicImDPK6JNsg bdYH3O4RXid+x+LVINbSt0OUx+1AGiRX7n1WbG6u7HJwAHIb0bonvEl3zmZSlWdF/OjpQMbOq 4e6FRzS4X40r4esbmZlfomidDlZSbyUIuw7rULVZPdSuPm1rGPNowuDdMZZyio3V4DcaCK+Oy NM2FppsaKuOvwkDAGA6bWkKKaRHdkzveZuPAgC18gTciJTg58INzQebTrTlbbPE3cazrmak6y 59Tz6Kk8GemyQyB92HnGtsMb/rVQ4CGlMZs43L1Zv22KCGHkPpyh+4QnKnsHTxbBvcutagWwR l07nURs68w9Q85bbYCW6y7uhw0Fandi/Eq/V8VRQbss5zuwL8/VmchWy/NsAz6NvtqfcIuTAF TvS+to5lep+5iuzOyvJmspLoTaCbjCeAovhb6Hl6YGva6Lt/sw0PEJon4C+eYmoYQPV1+dLWf 8KIpCAxycpEmMqezPztkSSSHfSxRD3sLLik/SQ0In3rP5BX/MaingRvMz2lJDN74D7G9u9Uy2 jxljz60CGIRWzmhyfF6/5Sa3rI6+pju7BahdE8n0Opgco1k0pGFz48thgaFbDpz4Ab552VTX5 /Vld1vSpml8kPI4v10dmUWj4s5alFJWkHp6vB1w5oA81D+/GaOPMfQJkJQgmsJvzU7qadvK+M 2zsrQOejkE+2ecnWvnVbIcS8MRkRTFhxog7HcIDjjiF6znlda+ecO4xLosz/cc+h/3QowlQQX lEsBqDGpsZBRPHH36oozXZTdznoAjXdxKZL/6H+cnw0Ck5HqVFC/3rl/wjMeCUPJvUoFXi+v X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:18021 Archived-At: ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mark H Weaver skribis: > >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> >>> ludo@gnu.org (Ludovic Court=C3=A8s) skribis: >>> >>>> Andreas Rottmann skribis: >>>> >>>>> Adds an implementation of SRFI 25 on top of Guile's native arrays. The >>>>> implementation does not introduce a disjoint type; Guile arrays and >>>>> SRFI-25 arrays can be used interchangably, though with different, par= tly >>>>> conflicting APIs. >>>>> >>>>> [...] >>>> >>>> If there are no objections, you can push this patch within a day or two >>>> to =E2=80=98stable-2.0=E2=80=99 (or I=E2=80=99ll do it if you happen t= o be unavailable.) >>> >>> Done in aaea5b2 with minor modifications in srfi-modules.texi to make it >>> more consistent with the rest of the manual. >> >> This commit broke the build, because it forgot to add srfi-25.scm. >> >> For now, I reverted the commit instead of fixing it, because there are a >> few other problems with srfi-25.scm which I had told Andreas about over >> IRC but never posted about. Sorry about that. I guess maybe that's why >> Andreas didn't respond more quickly to your earlier email. >> Yep, I didn't come around to address these issues, and assumed they were communicated and taken into consideration when Ludo stated his intention to apply my patch. >> In a couple of places, it has code like this: >> >> + (cond ((array? i) >> + (apply array-ref array (array->index-list i))) >> + ((vector? i) >> + (apply array-ref array (vector->list i))) >> >> Since every vector is also considered an array, the second clause of the >> 'cond' is dead code. >> >> Also, it would be good to avoid consing in common cases in 'array-ref' >> and 'array-set!', by adding special cases for 1 and 2 dimensional array >> accesses, at least when the indices are given as direct arguments. >> >> Finally, the following line should be put somewhere in the module: >> >> (cond-expand-provide (current-module) '(srfi-25)) > > Too much asynchrony here. ;-) I hope Andreas or you can look into it. > I hope I'll have time to look into it tomorrow, and post a patch based on Ludo's adaptions, addressing the issues raised by Mark; thanks for cleaning up the docs Ludo, BTW! Regards, Rotty --=20 Andreas Rottmann --