From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel,gmane.comp.gnu.guix.devel Subject: Re: [PATCH] gnu: Add erlang. Date: Mon, 04 Jan 2016 12:44:24 +0100 Message-ID: <877fjpzi07.fsf@igalia.com> References: <20160104043952.GA29303@jasmine> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451907924 5357 80.91.229.3 (4 Jan 2016 11:45:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Jan 2016 11:45:24 +0000 (UTC) Cc: guix-devel@gnu.org, guile-devel@gnu.org, Leo Famulari To: Steve Sprang Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jan 04 12:45:14 2016 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aG3Za-0007my-2W for guile-devel@m.gmane.org; Mon, 04 Jan 2016 12:45:14 +0100 Original-Received: from localhost ([::1]:44626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aG3ZZ-0003rW-Ab for guile-devel@m.gmane.org; Mon, 04 Jan 2016 06:45:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aG3ZW-0003rN-Er for guile-devel@gnu.org; Mon, 04 Jan 2016 06:45:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aG3ZS-0000i4-9K for guile-devel@gnu.org; Mon, 04 Jan 2016 06:45:10 -0500 Original-Received: from pb-sasl0.int.icgroup.com ([208.72.237.25]:57364 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aG3ZS-0000Sl-3F; Mon, 04 Jan 2016 06:45:06 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl0.pobox.com (Postfix) with ESMTP id D3C043571A; Mon, 4 Jan 2016 06:44:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=wZS9HoaNEDyljWr1Yy0CEZZYOC4=; b=KjWZd1 Q62e4CI99s0VmMKQRBOtjst/DHukijB261snew7tHmdddkzj4X7NKZWLvja35vGd 9/gWPbjeNUIcO7eWiGMAeKmSZmoC/w9wvvlJ2KWi8O9OMJb1MqA9qH+EaoVCQG6m nHn7lD1jBmghyvBhipW4IeaTURZz69DJCwP6o= Original-Received: from pb-sasl0.int.icgroup.com (unknown [127.0.0.1]) by pb-sasl0.pobox.com (Postfix) with ESMTP id CC65035719; Mon, 4 Jan 2016 06:44:28 -0500 (EST) Original-Received: from rusty (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl0.pobox.com (Postfix) with ESMTPSA id 08D6935718; Mon, 4 Jan 2016 06:44:26 -0500 (EST) In-Reply-To: (Steve Sprang's message of "Sun, 3 Jan 2016 21:20:45 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: 82CA8AEC-B2D8-11E5-B963-31311E2D4245-02397024!pb-sasl0.pobox.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.72.237.25 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:18104 gmane.comp.gnu.guix.devel:14844 Archived-At: On Mon 04 Jan 2016 06:20, Steve Sprang writes: > From http://www.erlang.org/download/otp_src_18.2.1.tar.gz... > ERROR: Bad qstring header component: kMSMAn68110840 This means the server is emitting bad HTTP. If I connect with: GET /download/otp_src_18.2.1.tar.gz HTTP/1.1 Host: www.erlang.org Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/601.1 (KHTML, like Gecko) Version/8.0 Safari/601.1 Epiphany/3.16.3 Accept-Encoding: gzip, deflate Accept-Language: en Connection: Keep-Alive The server responds with: HTTP/1.1 200 OK Server: inets/5.7.1 Date: Mon, 04 Jan 2016 11:32:30 GMT Content-Type: text/plain; charset=utf-8 Etag: kMSMAn68110840 Content-Length: 68110840 Last-Modified: Fri, 18 Dec 2015 11:00:38 GMT Connection:close ... The Etag value is invalid: https://tools.ietf.org/html/rfc7232#section-2.3 We could relax Guile's etag parser to assume that an etag not starting with either W/ or " is a strong etag without quotes. To do that you would patch guile's http.scm to say: (define (parse-entity-tag val) (cond ((string-prefix? "W/" val) (cons (parse-qstring val 2) #f)) ((string-prefix? "\"" val) (cons (parse-qstring val) #t)) (else (cons val #t)))) Considering that this error has come up a few times and that the less strict parser doesn't change the Guile programming interface or endanger the web in any significant way, I think changing Guile's HTTP parser would be OK. Thoughts? Andy