From: Andy Wingo <wingo@pobox.com>
To: "Thompson\, David" <dthompson2@worcester.edu>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] Add unboxed floating point comparison instructions.
Date: Mon, 09 Jan 2017 22:23:33 +0100 [thread overview]
Message-ID: <877f64apwq.fsf@pobox.com> (raw)
In-Reply-To: <CAJ=RwfYrVFZPxqXVR4NA3P8j0J1ZL01fHqPyQAoS4v_5YkSk2w@mail.gmail.com> (David Thompson's message of "Sun, 8 Jan 2017 20:09:41 -0500")
On Mon 09 Jan 2017 02:09, "Thompson, David" <dthompson2@worcester.edu> writes:
> + /* br-if-f64= a:12 b:12 invert:1 _:7 offset:24
Missing - before the =.
> + /* br-if-f64< a:12 b:12 invert:1 _:7 offset:24
Here too.
Please fix these nits and then LGTM; please push directly. Thanks!
Andy
next prev parent reply other threads:[~2017-01-09 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 1:47 [PATCH] Add unboxed floating point comparison instructions David Thompson
2016-12-14 14:51 ` Thompson, David
2016-12-21 19:11 ` Andy Wingo
2016-12-21 21:12 ` Mark H Weaver
2017-01-05 1:41 ` Thompson, David
2017-01-08 22:06 ` Andy Wingo
2017-01-09 1:09 ` Thompson, David
2017-01-09 21:23 ` Andy Wingo [this message]
2017-01-10 0:47 ` Thompson, David
2017-01-12 15:38 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f64apwq.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=dthompson2@worcester.edu \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).