From: Andy Wingo <wingo@igalia.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH 1/2] srfi-34: Replace the 'raise' core binding.
Date: Tue, 26 Nov 2019 11:09:25 +0100 [thread overview]
Message-ID: <877e3nt0dm.fsf@igalia.com> (raw)
In-Reply-To: <20191125164555.15124-2-ludo@gnu.org> ("Ludovic \=\?utf-8\?Q\?Cou\?\= \=\?utf-8\?Q\?rt\=C3\=A8s\=22's\?\= message of "Mon, 25 Nov 2019 17:45:54 +0100")
On Mon 25 Nov 2019 17:45, Ludovic Courtès <ludo@gnu.org> writes:
> In Guile 2.x, (srfi srfi-34) would already replace 'raise'. Replacing
> avoids a run-time warning about the core binding being overridden.
>
> * module/srfi/srfi-34.scm (raise): New variable.
> Mark it as #:replace instead of #:re-export.
> ---
> module/srfi/srfi-34.scm | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/module/srfi/srfi-34.scm b/module/srfi/srfi-34.scm
> index 0e7ad995d..255bfecb9 100644
> --- a/module/srfi/srfi-34.scm
> +++ b/module/srfi/srfi-34.scm
> @@ -1,6 +1,6 @@
> ;;; srfi-34.scm --- Exception handling for programs
>
> -;; Copyright (C) 2003, 2006, 2008, 2010 Free Software Foundation, Inc.
> +;; Copyright (C) 2003, 2006, 2008, 2010, 2019 Free Software Foundation, Inc.
> ;;
> ;; This library is free software; you can redistribute it and/or
> ;; modify it under the terms of the GNU Lesser General Public
> @@ -27,12 +27,16 @@
> ;;; Code:
>
> (define-module (srfi srfi-34)
> - #:re-export (with-exception-handler
> - (raise-exception . raise))
> + #:re-export (with-exception-handler)
> + #:replace (raise)
> #:export-syntax (guard))
>
> (cond-expand-provide (current-module) '(srfi-34))
>
> +(define (raise exn)
> + "Raise the given exception, invoking the current exception handler on EXN."
> + (raise-exception exn))
LGTM but it is better to re-export if possible. The reason is that
right now the compiler recognizes "throw" and "error" as not falling
through, and this is good for a number of reasons; it would be nice to
extend this to raise-exception. We should make it possible to re-export
and replace at the same time, IMO.
Andy
next prev parent reply other threads:[~2019-11-26 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:45 [PATCH 0/2] Silence run-time warnings for SRFI-3[45] Ludovic Courtès
2019-11-25 16:45 ` [PATCH 1/2] srfi-34: Replace the 'raise' core binding Ludovic Courtès
2019-11-26 10:09 ` Andy Wingo [this message]
2019-11-26 13:09 ` Ludovic Courtès
2019-11-29 11:00 ` Andy Wingo
2019-11-25 16:45 ` [PATCH 2/2] srfi-35: Replace '&error' Ludovic Courtès
2019-11-26 10:10 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e3nt0dm.fsf@igalia.com \
--to=wingo@igalia.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).