From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCHES] various commenting, whitespace changes Date: Fri, 27 Aug 2010 10:29:02 +0200 Message-ID: <8762yw8nn5.fsf@ambire.localdomain> References: <87bpazfgsq.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1282897994 26511 80.91.229.12 (27 Aug 2010 08:33:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 27 Aug 2010 08:33:14 +0000 (UTC) Cc: guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Aug 27 10:33:10 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OouN4-0008Ne-9b for guile-devel@m.gmane.org; Fri, 27 Aug 2010 10:33:10 +0200 Original-Received: from localhost ([127.0.0.1]:55534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OouN3-0006jj-KI for guile-devel@m.gmane.org; Fri, 27 Aug 2010 04:33:09 -0400 Original-Received: from [140.186.70.92] (port=47585 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OouMt-0006jc-K0 for guile-devel@gnu.org; Fri, 27 Aug 2010 04:33:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OouMs-0006Gf-A4 for guile-devel@gnu.org; Fri, 27 Aug 2010 04:32:59 -0400 Original-Received: from smtp207.alice.it ([82.57.200.103]:55976) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OouMs-0006GL-0H for guile-devel@gnu.org; Fri, 27 Aug 2010 04:32:58 -0400 Original-Received: from ambire.localdomain (95.236.70.138) by smtp207.alice.it (8.5.124.08) id 4C1A26CF0413BA5E; Fri, 27 Aug 2010 10:32:25 +0200 Original-Received: from ttn by ambire.localdomain with local (Exim 4.69) (envelope-from ) id 1OouJ4-0001Vv-Jm; Fri, 27 Aug 2010 10:29:02 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Windows 98 (1) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10787 Archived-At: () Andy Wingo () Mon, 28 Jun 2010 15:44:54 +0200 Sorry for the long delay in response. What does NFC mean? See LibreDWG HACKING (and build-aux/create-changelog), for more info: git://git.sv.gnu.org/libredwg.git It's useful to distinguish between "important" and "unimportant" changes, especially if recording changes (ChangeLog maintenance) is mechanical. A simple tag like this gives you the flexibility to make unimportant changes without the worry that such will end up as noise in the published ChangeLog. In general I'm a little uneasy with this kind of change, as it is unnecessary. No worries, lots of aesthetic/readability munging that i do falls into that category -- you'll get used to it. I think if you cut me some slack on this matter (and perhaps implement "nfc" (or similar) filtering as per LibreDWG create-changelog), you may find yourself not only more accepting of these kinds of changes but also doing them yourself. But, OK, I guess. Please feel free to make files more closely follow GNU conventions, when you are working on those files; but do avoid a general cleanup. I think it would drive me crazy ;) Perhaps Ludovic will chime in later with more general feedback. I will avoid general cleanup, but i don't intend to avoid cleanup on files i wish to hack on (for now, this set includes makefiles, build scripts and documentation). I hope this targeted approach will not drive you crazy. Rather, it would be ideal if you were to say "hey, thanks janitor ttn for handling that grunge -- keep up the good work!", after observing that these changes can coincide peacefully with your own hacking sphere (if you let that sphere become more transparent :-). > --- a/libguile/guile-func-name-check > +++ b/libguile/guile-func-name-check [...] > BEGIN { > - filename =3D ARGV[1]; > - in_a_func =3D 0; > + filename =3D ARGV[1]; > + in_a_func =3D 0; > } There is no need to change the indentation amount here; 2-space should be fine. [...] > +# guile-func-name-check ends here I would rather not have these markers. It's an extra point of bitrot. If you really want the end-of-file markers I would want some confirmation from Ludovic; otherwise, I am OK with you pushing these patches without the EOF markers and without changing the awk script indentation. I sidestepped these issues, by rewriting in Scheme (and using Emacs' =E2=80=98indent-sexp=E2=80=99). Unfortunately, it looks like hydra is not = liking it: http://hydra.nixos.org/build/606792 Perhaps a workaround would be to use =E2=80=98--no-autocompile=E2=80=99 in = the invocation command (libguile/guile-snarf-docs.in:55), but that seems ugly and throws away a bug-{hunt,squash}ing opportunity. WDYT? Another related idea: Since Guile supports many languages, why not AWK?