[PATCH] Fix linker error on Debian sid

[PATCH] Fix linker error on Debian sid

[Andreas Rottmann]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Hi!

Attached is a patch that fixes a linker error in the test suite when
using the default toolchain on Debian sid.  It should be applied to both
master and stable-2.0, I think.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-test-linkage.diff --]
[-- Type: text/x-diff, Size: 1138 bytes --]

From: Andreas Rottmann <a.rottmann@gmx.at>
Subject: Fix linking for test suite wrt. --no-add-needed

See
<http://wiki.debian.org/ToolChain/DSOLinking#Notresolvingsymbolsinindirectdependentsharedlibraries>
for a description of the issue.

* test-suite/standalone/Makefile.am (test_with_guile_module_LDADD): Add
  $(BWD_GC_LIBS), as those are referenced via the libgc pthread shims.

---
 test-suite/standalone/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/test-suite/standalone/Makefile.am b/test-suite/standalone/Makefile.am
index 861e668..f1f0716 100644
--- a/test-suite/standalone/Makefile.am
+++ b/test-suite/standalone/Makefile.am
@@ -176,7 +176,7 @@ if BUILD_PTHREAD_SUPPORT
 
 # test-with-guile-module
 test_with_guile_module_CFLAGS = ${test_cflags}
-test_with_guile_module_LDADD = ${top_builddir}/libguile/libguile-@GUILE_EFFECTIVE_VERSION@.la
+test_with_guile_module_LDADD = ${top_builddir}/libguile/libguile-@GUILE_EFFECTIVE_VERSION@.la $(BDW_GC_LIBS)
 check_PROGRAMS += test-with-guile-module
 TESTS += test-with-guile-module
 
-- 
tg: (229b4bd..) t/fix-test-linkage (depends on: master)

[-- Attachment #3: Type: text/plain, Size: 63 bytes --]


Regards, Rotty
-- 
Andreas Rottmann -- <http://rotty.yi.org/>

Re: [PATCH] Fix linker error on Debian sid

[Ludovic Courtès]

Hi Andreas,

Andreas Rottmann <a.rottmann@gmx.at> writes:

> Attached is a patch that fixes a linker error in the test suite when
> using the default toolchain on Debian sid.  It should be applied to both
> master and stable-2.0, I think.

Thanks, I applied a variant of the patch.

Ludo’.

Re: [PATCH] Fix linker error on Debian sid

[Darren Hoo]

Andreas Rottmann <a.rottmann@gmx.at> writes:

> Hi!
>
> Attached is a patch that fixes a linker error in the test suite when
> using the default toolchain on Debian sid.  It should be applied to both
> master and stable-2.0, I think.
>

Thanks for the patch! 
I really should have checked the mailinglist first before I struggled
with the compiling of unreleased BDWGC.

Is using  the CVS version of BDWGC a must in order to get Guile
multithread  support? with your patch, I can successfully build it with
libgc 1:7.1-6 in Debian unstable now,  but check-TESTS can not pass
gc.test, I Ctrl-C it when it stucks.