From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Improved source properties and errors; => within case Date: Fri, 10 Feb 2012 16:45:34 +0100 Message-ID: <8762feitep.fsf@gnu.org> References: <87haz18zet.fsf@netris.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1328888771 6420 80.91.229.3 (10 Feb 2012 15:46:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 10 Feb 2012 15:46:11 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Feb 10 16:46:08 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rvsfi-0007Iu-MD for guile-devel@m.gmane.org; Fri, 10 Feb 2012 16:46:02 +0100 Original-Received: from localhost ([::1]:39080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rvsfi-0007m3-4s for guile-devel@m.gmane.org; Fri, 10 Feb 2012 10:46:02 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:57315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvsfW-0007em-Bn for guile-devel@gnu.org; Fri, 10 Feb 2012 10:45:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvsfT-0003wz-E9 for guile-devel@gnu.org; Fri, 10 Feb 2012 10:45:50 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:58144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvsfT-0003wL-2K for guile-devel@gnu.org; Fri, 10 Feb 2012 10:45:47 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1RvsfP-00073i-Kv for guile-devel@gnu.org; Fri, 10 Feb 2012 16:45:43 +0100 Original-Received: from 193.50.110.167 ([193.50.110.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 10 Feb 2012 16:45:43 +0100 Original-Received: from ludo by 193.50.110.167 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 10 Feb 2012 16:45:43 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 38 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 193.50.110.167 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 =?iso-8859-1?Q?Pluvi=F4se?= an 220 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (gnu/linux) Cancel-Lock: sha1:EiIGttf8mgn6iKcI7iHDcPRIRaU= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:13836 Archived-At: Hi Mark, Sorry for not replying earlier. Mark H Weaver skribis: > From 849b96dd703315db31f41e01f10a1140391f82c1 Mon Sep 17 00:00:00 2001 > From: Mark H Weaver > Date: Tue, 7 Feb 2012 19:40:29 -0500 > Subject: [PATCH 5/5] Support => within case, and improve error messages for > cond and case > > * module/ice-9/boot-9.scm (cond, case): Reimplement using syntax-case, > with improved error messages and support for '=>' within 'case' as > mandated by the R7RS. Add warnings for duplicate case datums and > case datums that cannot be meaningfully compared using 'eqv?'. This looks like a useful addition. However, could it be done in the tree-il/analyze.scm instead, along with other warning passes? The reason I’m asking is that this: > * module/system/base/message.scm (%warning-types): Add 'bad-case-datum' > and 'duplicate-case-datum' warning types. ... is really meant for compiler warnings (see, for instance, the output of ‘guild compile -Whelp’). In particular, whether the warnings are emitted is determined by a #:opts sub-option to ‘compile’. WDYT? In addition, it would be great to have tests for the warnings themselves, as found at the bottom of tree-il.test. Thanks, Ludo’