unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Futures: Avoid creating the worker pool more than once
Date: Fri, 30 Nov 2012 14:01:24 -0500	[thread overview]
Message-ID: <87624mx6d7.fsf@tines.lan> (raw)
In-Reply-To: <87pq3dw35w.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 17 Nov 2012 00:15:07 +0100")

Hi Ludovic,

Sorry for not responding to this earlier.

ludo@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver <mhw@netris.org> skribis:
>
>> diff --git a/module/ice-9/futures.scm b/module/ice-9/futures.scm
>> index 0f64b5c..7fbccf6 100644
>> --- a/module/ice-9/futures.scm
>> +++ b/module/ice-9/futures.scm
>> @@ -19,6 +19,7 @@
>>  (define-module (ice-9 futures)
>>    #:use-module (srfi srfi-1)
>>    #:use-module (srfi srfi-9)
>> +  #:use-module (ice-9 threads)
>>    #:use-module (ice-9 q)
>>    #:export (future make-future future? touch))
>
> I just realized that this patch introduces a circular dependency between
> the two modules.

Why is this a problem?  I think circular dependencies are fine as long
as there is not a cycle composed entirely of syntactic keyword
dependencies.

After introducing this circular dependency, I successfully bootstrapped
from scratch without difficulties.

What am I missing here?

      Mark



  reply	other threads:[~2012-11-30 19:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 23:07 [PATCH] Futures: Avoid creating the worker pool more than once Mark H Weaver
2012-11-07 13:46 ` Mark H Weaver
2012-11-07 14:14   ` Daniel Hartwig
2012-11-16 23:15   ` Ludovic Courtès
2012-11-30 19:01     ` Mark H Weaver [this message]
2012-11-30 20:14       ` Ludovic Courtès
2012-11-08 19:11 ` Ludovic Courtès
2012-11-10  3:13   ` Mark H Weaver
2012-11-10 13:53     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87624mx6d7.fsf@tines.lan \
    --to=mhw@netris.org \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).