From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.7-29-ge211d69 Date: Wed, 16 Jan 2013 16:54:17 +0100 Message-ID: <87622xf7iu.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1358351666 19696 80.91.229.3 (16 Jan 2013 15:54:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Jan 2013 15:54:26 +0000 (UTC) Cc: guile-devel@gnu.org To: "Andy Wingo" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Jan 16 16:54:42 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TvVK4-0006op-E4 for guile-devel@m.gmane.org; Wed, 16 Jan 2013 16:54:40 +0100 Original-Received: from localhost ([::1]:35224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvVJn-00032H-VH for guile-devel@m.gmane.org; Wed, 16 Jan 2013 10:54:23 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:32939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvVJk-00031a-Io for guile-devel@gnu.org; Wed, 16 Jan 2013 10:54:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvVJj-0006Z5-Fw for guile-devel@gnu.org; Wed, 16 Jan 2013 10:54:20 -0500 Original-Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:12240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvVJj-0006Yp-9M for guile-devel@gnu.org; Wed, 16 Jan 2013 10:54:19 -0500 X-IronPort-AV: E=Sophos;i="4.84,479,1355094000"; d="scan'208";a="190223547" Original-Received: from reverse-83.fdn.fr (HELO pluto) ([80.67.176.83]) by mail1-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 16 Jan 2013 16:54:17 +0100 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 =?utf-8?Q?Niv=C3=B4se?= an 221 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: (Andy Wingo's message of "Tue, 15 Jan 2013 15:41:35 +0000") User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.134.164.82 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15450 Archived-At: "Andy Wingo" skribis: > fix string->bytevector for utf-8 and non-error conversion strategies >=20=20=20=20=20 > * module/ice-9/iconv.scm (call-with-encoded-output-string): > (string->bytevector, bytevector->string): Only call string->utf8 and > utf8->string if the conversion strategy is `error'. string->bytevector cannot fail when the encoding is UTF-8. As for bytevector->string, you should compare against (%default-port-conversion-strategy) rather than 'error, I think. Would be nice to have tests for these corner cases. Ludo=E2=80=99.