From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Bindings for =?utf-8?B?4oCYc2VuZGZpbGXigJk=?= Date: Fri, 22 Mar 2013 15:22:19 -0400 Message-ID: <87620j8ck4.fsf@tines.lan> References: <87ip4liufs.fsf@gnu.org> <878v5hbblk.fsf@tines.lan> <87obed2iqo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1363980173 12019 80.91.229.3 (22 Mar 2013 19:22:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Mar 2013 19:22:53 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Mar 22 20:23:16 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UJ7YX-00029Q-JQ for guile-devel@m.gmane.org; Fri, 22 Mar 2013 20:23:13 +0100 Original-Received: from localhost ([::1]:43209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ7YA-0006wp-58 for guile-devel@m.gmane.org; Fri, 22 Mar 2013 15:22:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ7Y5-0006wZ-Fj for guile-devel@gnu.org; Fri, 22 Mar 2013 15:22:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJ7Y3-0003J3-TE for guile-devel@gnu.org; Fri, 22 Mar 2013 15:22:45 -0400 Original-Received: from world.peace.net ([96.39.62.75]:45768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ7Y3-0003I0-PN; Fri, 22 Mar 2013 15:22:43 -0400 Original-Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=tines.lan) by world.peace.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UJ7Xm-0000RG-RB; Fri, 22 Mar 2013 15:22:27 -0400 In-Reply-To: <87obed2iqo.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 21 Mar 2013 10:40:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 96.39.62.75 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15968 Archived-At: ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mark H Weaver skribis: > >> Since the code below will behave badly if 'c_count' does not fit in an >> 'ssize_t', we should validate here that it _does_ fit. > > Oops, indeed. (Note that sendfile(2) and write(2) have that problem: > they take a size_t and return a ssize_t...) > > There was also the other issue of making sure we use the right function, > depending on _FILE_OFFSET_BITS & co. > > Here are the changes compared to the previous patch: [...] > WDYT? Looks good to me! :) Mark