unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] web: uri-encode hexadecimal percent-encoding is now uppercase
Date: Thu, 02 May 2013 14:53:29 -0400	[thread overview]
Message-ID: <8761z1gqmu.fsf@tines.lan> (raw)
In-Reply-To: <CA+XASoVOmZt39LiOGAW7=Y+P3Q2nOOgr=H7_VnOv5pLQy2SkhA@mail.gmail.com> ("Aleix Conchillo \=\?utf-8\?Q\?Flaqu\=C3\=A9\=22's\?\= message of "Thu, 2 May 2013 10:44:20 -0700")

Hi Aleix,

This patch looks good to me, except that I don't like the variable name
'num' for a string.  Actually, I'm not sure we need to bind that to a
variable at all.  How about just wrapping 'string-upcase' around the
call to 'number->string'?

      Thanks,
        Mark


> @@ -396,11 +396,12 @@ hexadecimal representation of the byte."
>                         (len (bytevector-length bv)))
>                    (let lp ((i 0))
>                      (if (< i len)
> -                        (let ((byte (bytevector-u8-ref bv i)))
> +                        (let* ((byte (bytevector-u8-ref bv i))
> +                               (num (number->string byte 16)))
>                            (display #\% port)
>                            (when (< byte 16)
>                              (display #\0 port))
> -                          (display (number->string byte 16) port)
> +                          (display (string-upcase num) port)
>                            (lp (1+ i))))))))
>            str)))
>        str))



  reply	other threads:[~2013-05-02 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 17:44 [PATCH] web: uri-encode hexadecimal percent-encoding is now uppercase Aleix Conchillo Flaqué
2013-05-02 18:53 ` Mark H Weaver [this message]
2013-05-02 19:15   ` Aleix Conchillo Flaqué
2013-05-02 21:17     ` Mark H Weaver
2013-05-02 23:50       ` Aleix Conchillo Flaqué

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761z1gqmu.fsf@tines.lan \
    --to=mhw@netris.org \
    --cc=aconchillo@gmail.com \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).