From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: Fwd: PATCH - Add cooperative REPL server module Date: Tue, 21 Jan 2014 22:36:29 -0500 Message-ID: <8761pcofgi.fsf@netris.org> References: <877g9vbw2s.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87ha8zpj93.fsf@netris.org> <874n4yoc5b.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87d2jmpn4e.fsf@netris.org> <874n4ynsbw.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87zjmqnevz.fsf@netris.org> <871u00u6kv.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1390362017 16855 80.91.229.3 (22 Jan 2014 03:40:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jan 2014 03:40:17 +0000 (UTC) Cc: guile-devel@gnu.org To: David Thompson Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Jan 22 04:40:24 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W5ofv-0003ff-BE for guile-devel@m.gmane.org; Wed, 22 Jan 2014 04:40:23 +0100 Original-Received: from localhost ([::1]:33436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5ofu-0000kW-U6 for guile-devel@m.gmane.org; Tue, 21 Jan 2014 22:40:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5ofk-0000eu-KE for guile-devel@gnu.org; Tue, 21 Jan 2014 22:40:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5ofd-0002jg-BA for guile-devel@gnu.org; Tue, 21 Jan 2014 22:40:12 -0500 Original-Received: from world.peace.net ([96.39.62.75]:56779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5ofd-0002i6-84 for guile-devel@gnu.org; Tue, 21 Jan 2014 22:40:05 -0500 Original-Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1W5ofW-0001V5-Ig; Tue, 21 Jan 2014 22:39:58 -0500 In-Reply-To: <871u00u6kv.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Tue, 21 Jan 2014 20:51:44 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 96.39.62.75 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16828 Archived-At: Hi David, Your latest patch looks great to me. I have only one request: please update the docstrings of 'spawn-coop-repl-server' and 'poll-coop-repl-server' to match their current descriptions in the manual, except without texinfo markup, as usual. Other than that, I think the patch is ready to push, although of course MVars have to go in first. Now it's my turn to write docs, and tests :) Thanks again! Mark