From: ludo@gnu.org (Ludovic Courtès)
To: Eli Zaretskii <eliz@gnu.org>
Cc: Mark H Weaver <mhw@netris.org>, guile-devel@gnu.org
Subject: Re: Don't skip popen.test on MinGW
Date: Mon, 30 Jun 2014 13:10:18 +0200 [thread overview]
Message-ID: <8761ji3b6t.fsf@gnu.org> (raw)
In-Reply-To: <83mwcv66k0.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jun 2014 19:09:51 +0300")
Eli Zaretskii <eliz@gnu.org> skribis:
> Another issue related to open-process is that popen.test was being
> skipped because if-supported returns #f. I fixed it thusly:
>
> (define-syntax-rule (if-supported body ...)
> (if (or (provided? 'fork)
> ((string-contains %host-type "-mingw32")))
> (begin body ...)))
>
> Is this OK? Again, perhaps the test should be removed, and popen.test
> should be run unconditionally?
‘if-supported’ was also added when addressing MinGW issues as part of
<http://bugs.gnu.org/13848>.
For now I think it’s best to change it to:
(define-syntax-rule (if-supported body ...)
(begin body ...))
Ludo’.
next prev parent reply other threads:[~2014-06-30 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 16:09 Don't skip popen.test on MinGW Eli Zaretskii
2014-06-30 11:10 ` Ludovic Courtès [this message]
2014-06-30 14:51 ` Eli Zaretskii
2014-07-03 16:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761ji3b6t.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=eliz@gnu.org \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).