From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Rottmann Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH 2/3] Add C++ extern "C" guards to internal headers. Date: Tue, 14 Jul 2015 21:36:31 +0200 Message-ID: <87615mjzuo.fsf@delenn.home.rotty.xx.vu> References: <1436897249-18167-1-git-send-email-ahmed.taahir@gmail.com> <1436897249-18167-3-git-send-email-ahmed.taahir@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1436902618 8261 80.91.229.3 (14 Jul 2015 19:36:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jul 2015 19:36:58 +0000 (UTC) Cc: guile-devel@gnu.org To: Taahir Ahmed Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Jul 14 21:36:46 2015 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZF60U-0003kk-6t for guile-devel@m.gmane.org; Tue, 14 Jul 2015 21:36:46 +0200 Original-Received: from localhost ([::1]:32769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF60T-0002RA-I0 for guile-devel@m.gmane.org; Tue, 14 Jul 2015 15:36:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF60O-0002R4-PB for guile-devel@gnu.org; Tue, 14 Jul 2015 15:36:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZF60M-0001cl-0E for guile-devel@gnu.org; Tue, 14 Jul 2015 15:36:40 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:63438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF60L-0001cY-M7 for guile-devel@gnu.org; Tue, 14 Jul 2015 15:36:37 -0400 Original-Received: from delenn.home.rotty.xx.vu ([91.119.182.207]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Lug4m-1YojOk37my-00zlx7; Tue, 14 Jul 2015 21:36:35 +0200 Original-Received: by delenn.home.rotty.xx.vu (Postfix, from userid 1000) id E5110327307; Tue, 14 Jul 2015 21:36:31 +0200 (CEST) In-Reply-To: <1436897249-18167-3-git-send-email-ahmed.taahir@gmail.com> (Taahir Ahmed's message of "Tue, 14 Jul 2015 13:07:28 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-Provags-ID: V03:K0:T+jYzTZtt9zJyCWbx3clSSWMQZ3vsPHlv4+QRYSioC/BbYoHkOH 5zRwKaRdXvMnW85MVmLlcRG0SKWBS0d7OMcgrcCfbAMrnnEb5cDaLpCHLUcOpMf1nqGpcLc RcUFOkHd6oOFRtxavI6jh8m0DnPT3sgRhAf+C7Ya2dz9n29bf4r/ToacRhaivNca+adWlEX V+q9rR5yY5Yx/LdhZByvQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:bkZI5V9Zje4=:41nMpx5kXbmBH9oknOjbzK DT0vTss0Y9KZjrii3aB/AIbDdKqu+bprb8ZgUxvxpfDCOXRRRdRN/brwYaWezwH3yfkcN68Dd 4hCcGplaj+rEE8VzYX+1sETLo4/rSmeiw8Gq6PqxWziuGJsC5+dAuuM87fyo42KydDo4jBOue vIS1Zj5LQJtFd3AhoFdz8UYPDMm4v+6cx4QxXR/5Xv8gv7XtnMfbM4YGikKyzeD148do9DKzW vm+S7sTRvmKzeotWFD0JN+rURzkfxF0NnUsfdPZSiTA7J0HYcWaTa+L3dZIYlhRKE8z12rhiE sdnLg+52BrCuhatr0nVUKrIrovfdKxyAqFpGxpKhUNNrxCysDjzrHG3eFSsfBwxgc9h86OFut X1Z/EJ6YZT/0HRsn76yDXebXhoVdB2BbD3jbiVkuOdtgTwOyvMngjq+3S4dMxhXoDD+gzh9zq Oa2GVMXe6wYLWOcFxbweQIkWbPDe1CgorjViSYzDjH0EmQv/9RDZ3W4zrbGbpg+O8x58WfT+R qSKQ8ASZ8+NPDL6EJ7c0Op/hVBjMSC8YZ1Lh5KwPnLlh4df5ot6FNQOp7y3dWx92lnj8/+JCu GSRFqGH1vLftfXLDtByUpL+h8Kssjt7ZXI0TJ9ntRam6zPXpsYoqilGgP0IBfL3oR9KBFM34Y 5ML18PRTdqoAUIxUX7eIJIherOvTmUXqqusnx7Z1hgTceE/8wyOmYaV2C6pvVSIyBcb4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17764 Archived-At: Taahir Ahmed writes: > --- > libguile/__scm.h | 8 ++++++++ > [...] > > diff --git a/libguile/__scm.h b/libguile/__scm.h > index 31e3952..1967069 100644 > --- a/libguile/__scm.h > +++ b/libguile/__scm.h > @@ -53,6 +53,10 @@ > /* What did the configure script discover about the outside world? */ > #include "libguile/scmconfig.h" > > +#ifdef __cplusplus > +extern "C" { > +#endif > + > > > > /* {Compiler hints} > @@ -523,6 +527,10 @@ typedef long SCM_STACKITEM; > # define SCM_THREAD_LOCAL > #endif > > +#ifdef __cplusplus > +} > +#endif > + > #endif /* SCM___SCM_H */ > Just a minor nitpick: it might make sense to add a pair of macros to libguile/__scm.h for the '#ifdef __cplusplus' dance, so these boilerplate additions become just two lines, e.g.: + SCM_BEGIN_DECLS ... + SCM_END_DECLS This is done in GLib, for example, and cuts down the noise a bit. Regards, Rotty -- Andreas Rottmann --