From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludovic.courtes@laas.fr (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Inlining `scm_is_pair ()' Date: Fri, 27 Jan 2006 10:13:46 +0100 Organization: LAAS-CNRS Message-ID: <874q3qt4mt.fsf@laas.fr> References: <87wti7pwie.fsf@laas.fr> <87ek4ftgge.fsf@zagadka.de> <87fyouitqo.fsf@laas.fr> <87psnxxswj.fsf@laas.fr> <87slrednt9.fsf_-_@laas.fr> <87k6cpwfkw.fsf@zip.com.au> <87oe20br3b.fsf@laas.fr> <87ek2u8twu.fsf@zip.com.au> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1138353641 1082 80.91.229.2 (27 Jan 2006 09:20:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 27 Jan 2006 09:20:41 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Jan 27 10:20:38 2006 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F2PmT-0007cZ-Nk for guile-devel@m.gmane.org; Fri, 27 Jan 2006 10:20:34 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F2Pnj-0007Ls-Bm for guile-devel@m.gmane.org; Fri, 27 Jan 2006 04:21:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F2Pm1-0006sW-JA for guile-devel@gnu.org; Fri, 27 Jan 2006 04:20:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F2PlU-0006c7-0z for guile-devel@gnu.org; Fri, 27 Jan 2006 04:19:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F2PjQ-0006Jj-Hc for guile-devel@gnu.org; Fri, 27 Jan 2006 04:17:25 -0500 Original-Received: from [140.93.0.15] (helo=laas.laas.fr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1F2Ph7-00036C-Nt for guile-devel@gnu.org; Fri, 27 Jan 2006 04:15:02 -0500 Original-Received: by laas.laas.fr (8.13.1/8.13.4) with SMTP id k0R9ENKa001116; Fri, 27 Jan 2006 10:14:25 +0100 (CET) Original-To: guile-devel@gnu.org X-URL: http://www.laas.fr/~lcourtes/ X-Revolutionary-Date: 8 =?iso-8859-1?Q?Pluvi=F4se?= an 214 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEB1F5364 X-PGP-Key: http://www.laas.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: powerpc-unknown-linux-gnu Mail-Followup-To: guile-devel@gnu.org In-Reply-To: <87ek2u8twu.fsf@zip.com.au> (Kevin Ryde's message of "Fri, 27 Jan 2006 10:13:21 +1100") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) X-Spam-Score: 0.496 () MAILTO_TO_SPAM_ADDR X-Scanned-By: MIMEDefang at CNRS-LAAS X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:5632 Archived-At: Kevin Ryde writes: > I doubt you'll ever get any feedback like that. Making something that > takes advantage of gcc but does no harm in vanilla c89 or c99 is in a > sense the best of both worlds. C99 defines `inline', so nothing wrong problem with that. As for C89, it would do no harm with it: the function's code will simply be duplicated in all files that use it, except that it will not be inlined. At worst, some compilers may raise warnings about the function being declared as `static' but unused. To me, this looks acceptable. If anyone has better suggestions, that's cool. But please, don't leave `scm_is_pair ()' as is. Thanks, Ludovic. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel