From: ludovic.courtes@laas.fr (Ludovic Courtès)
Subject: Re: [PATCH] Inlining `scm_is_pair ()'
Date: Fri, 27 Jan 2006 10:13:46 +0100 [thread overview]
Message-ID: <874q3qt4mt.fsf@laas.fr> (raw)
In-Reply-To: <87ek2u8twu.fsf@zip.com.au> (Kevin Ryde's message of "Fri, 27 Jan 2006 10:13:21 +1100")
Kevin Ryde <user42@zip.com.au> writes:
> I doubt you'll ever get any feedback like that. Making something that
> takes advantage of gcc but does no harm in vanilla c89 or c99 is in a
> sense the best of both worlds.
C99 defines `inline', so nothing wrong problem with that. As for C89,
it would do no harm with it: the function's code will simply be
duplicated in all files that use it, except that it will not be
inlined. At worst, some compilers may raise warnings about the function
being declared as `static' but unused.
To me, this looks acceptable. If anyone has better suggestions, that's
cool. But please, don't leave `scm_is_pair ()' as is.
Thanks,
Ludovic.
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2006-01-27 9:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 14:46 [PATCH] Turning `scm_is_pair ()' into a macro Ludovic Courtès
2005-12-14 20:57 ` Kevin Ryde
2005-12-14 23:00 ` Han-Wen Nienhuys
2005-12-14 23:19 ` Marius Vollmer
2005-12-15 9:39 ` Ludovic Courtès
2005-12-16 0:08 ` Han-Wen Nienhuys
2005-12-16 10:01 ` Ludovic Courtès
2006-01-24 8:37 ` [PATCH] Inlining `scm_is_pair ()' Ludovic Courtès
2006-01-24 20:12 ` Kevin Ryde
2006-01-25 9:21 ` Ludovic Courtès
2006-01-26 23:13 ` Kevin Ryde
2006-01-27 9:13 ` Ludovic Courtès [this message]
2006-01-28 22:07 ` Marius Vollmer
2006-01-30 9:06 ` Ludovic Courtès
2006-02-03 23:49 ` Kevin Ryde
2006-02-05 19:10 ` Marius Vollmer
2005-12-16 0:41 ` [PATCH] Turning `scm_is_pair ()' into a macro Kevin Ryde
2005-12-16 20:01 ` Marius Vollmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874q3qt4mt.fsf@laas.fr \
--to=ludovic.courtes@laas.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).