From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Neil Jerram Newsgroups: gmane.lisp.guile.devel Subject: Re: Pkgsrc patches: patch-aj Date: Wed, 27 Feb 2008 21:27:07 +0000 Message-ID: <874pbu8504.fsf@ossau.uklinux.net> References: <87tzketg12.fsf@gnu.org> <87y79puca8.fsf@ossau.uklinux.net> <87prv0sixe.fsf@inbox.ru> <87ejbg0yhj.fsf@ambire.localdomain> <87odajqv8s.fsf@inbox.ru> <87ir0r9yrb.fsf_-_@gnu.org> <87mypnfkgx.fsf@ossau.uklinux.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204147656 18494 80.91.229.12 (27 Feb 2008 21:27:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Feb 2008 21:27:36 +0000 (UTC) Cc: Ludovic =?iso-8859-1?Q?Court=E8s?= , guile-devel@gnu.org To: Greg Troxel Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Feb 27 22:28:02 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUToh-0003FE-7s for guile-devel@m.gmane.org; Wed, 27 Feb 2008 22:27:55 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUToB-0001QZ-1n for guile-devel@m.gmane.org; Wed, 27 Feb 2008 16:27:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUTo5-0001Pt-Nd for guile-devel@gnu.org; Wed, 27 Feb 2008 16:27:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUTo3-0001NS-Vw for guile-devel@gnu.org; Wed, 27 Feb 2008 16:27:17 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUTo3-0001ND-Sg for guile-devel@gnu.org; Wed, 27 Feb 2008 16:27:15 -0500 Original-Received: from mail3.uklinux.net ([80.84.72.33]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUTnz-0004yz-Qc; Wed, 27 Feb 2008 16:27:11 -0500 Original-Received: from arudy (host86-145-183-175.range86-145.btcentralplus.com [86.145.183.175]) by mail3.uklinux.net (Postfix) with ESMTP id F3B101F6DB2; Wed, 27 Feb 2008 21:27:09 +0000 (GMT) Original-Received: from laruns (laruns [192.168.0.10]) by arudy (Postfix) with ESMTP id 6788D3800A; Wed, 27 Feb 2008 21:27:08 +0000 (GMT) In-Reply-To: (Greg Troxel's message of "Wed, 27 Feb 2008 07:20:10 -0500") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7055 Archived-At: Greg Troxel writes: > Neil Jerram writes: > > I have looked at this in more detail, to understand more precisely what > pkgsrc changed, in order to make sure I'm not suggesting that we throw > out a fix to an actual problem. Thanks for your time on this! >> The include isn't needed here, because errno.h was already included >> earlier on in the same file. > > Agreed, so I will remove the include from patch-aj (which dates from 1.6). Cool. > I did a build with the following patch instead: > > $NetBSD$ > > --- libguile/_scm.h.orig 2008-02-06 08:09:18.000000000 -0500 > +++ libguile/_scm.h > @@ -95,14 +95,6 @@ > # define SCM_SYSCALL(line) line; > #endif /* ndef SCM_SYSCALL */ > > -#if !defined (MSDOS) && !defined (__MINGW32__) > -# ifdef ARM_ULIB > - extern volatile int errno; > -# else > - extern int errno; > -# endif /* def ARM_ULIB */ > -#endif /* ndef MSDOS && ndef __MINGW32__*/ > - > > > #ifndef min > > and then 1.8.4 builds and 'make check's ok on NetBSD-current i386. > > I have put the above patch into pkgsrc, and I think it should be applied > in guile. Yes, that works fine for me too on GNU/Linux, and I can't imagine any system where it won't - so I've committed this change now to CVS. Neil