From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Neil Jerram Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] (Symbol Primitives): Add symbol, list->symbol, symbol-append. Date: Sun, 31 May 2009 00:41:15 +0100 Message-ID: <874ov2rwf8.fsf@arudy.ossau.uklinux.net> References: <194496.20620.qm@web83408.mail.sp1.yahoo.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1243726891 25242 80.91.229.12 (30 May 2009 23:41:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 May 2009 23:41:31 +0000 (UTC) Cc: guile-devel@gnu.org To: Mark Polesky Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun May 31 01:41:27 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MAYB5-0006Be-DM for guile-devel@m.gmane.org; Sun, 31 May 2009 01:41:27 +0200 Original-Received: from localhost ([127.0.0.1]:35699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MAYB4-0007gJ-OV for guile-devel@m.gmane.org; Sat, 30 May 2009 19:41:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MAYB0-0007g6-3x for guile-devel@gnu.org; Sat, 30 May 2009 19:41:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MAYAv-0007fS-Iv for guile-devel@gnu.org; Sat, 30 May 2009 19:41:21 -0400 Original-Received: from [199.232.76.173] (port=48003 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MAYAv-0007fP-GE for guile-devel@gnu.org; Sat, 30 May 2009 19:41:17 -0400 Original-Received: from mail3.uklinux.net ([80.84.72.33]:56495) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MAYAv-0003pw-4F for guile-devel@gnu.org; Sat, 30 May 2009 19:41:17 -0400 Original-Received: from arudy (host86-152-99-133.range86-152.btcentralplus.com [86.152.99.133]) by mail3.uklinux.net (Postfix) with ESMTP id 57F141F6E5A; Sun, 31 May 2009 00:41:16 +0100 (BST) Original-Received: from arudy.ossau.uklinux.net (arudy [127.0.0.1]) by arudy (Postfix) with ESMTP id B8D1038013; Sun, 31 May 2009 00:41:15 +0100 (BST) In-Reply-To: <194496.20620.qm@web83408.mail.sp1.yahoo.com> (Mark Polesky's message of "Sat\, 30 May 2009 08\:51\:44 -0700 \(PDT\)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8573 Archived-At: Mark Polesky writes: > Mark Polesky wrote: > >> Did I do this right? If so, could someone apply this patch? I >> didn't quite follow all the details in doc/maint/README, perhaps >> because I'm on Windows, and I don't use emacs. Let me know. Hi Mark, Many thanks for contributing this patch. As it is more than a few lines, we would need to get a copyright assignment from you before we could incorporate it into Guile. If you'd be willing to do that, please reply to me off-list and I'll send you the relevant instructions. There's also one technical problem with the patch: the new doc says "newly allocated", which is wrong because these procedures all return interned symbols - which means that an important aspect of them is that they will return an existing symbol if there is one with the right name. Would you like to propose some new wording to allow for this? Alternatively, and assuming that you're happy to do the copyright assignment, I'm sure I could think up something when I apply the patch. Regards, Neil