From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-8-23-gea6b18e Date: Sun, 28 Feb 2010 22:31:56 +0100 Message-ID: <874ol12gj7.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1267392733 10563 80.91.229.12 (28 Feb 2010 21:32:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 28 Feb 2010 21:32:13 +0000 (UTC) Cc: guile-devel@gnu.org To: "Andy Wingo" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Feb 28 22:32:09 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NlqkC-00075y-Jf for guile-devel@m.gmane.org; Sun, 28 Feb 2010 22:32:08 +0100 Original-Received: from localhost ([127.0.0.1]:48443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nlqk9-0002Xq-Ht for guile-devel@m.gmane.org; Sun, 28 Feb 2010 16:32:05 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nlqk6-0002Xk-Py for guile-devel@gnu.org; Sun, 28 Feb 2010 16:32:02 -0500 Original-Received: from [140.186.70.92] (port=48075 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nlqk5-0002Xb-Tq for guile-devel@gnu.org; Sun, 28 Feb 2010 16:32:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nlqk4-0001k3-VT for guile-devel@gnu.org; Sun, 28 Feb 2010 16:32:01 -0500 Original-Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:30033) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nlqk4-0001jx-Pv for guile-devel@gnu.org; Sun, 28 Feb 2010 16:32:00 -0500 X-IronPort-AV: E=Sophos;i="4.49,557,1262559600"; d="scan'208";a="53754356" Original-Received: from reverse-83.fdn.fr (HELO nixey) ([80.67.176.83]) by mail1-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 28 Feb 2010 22:31:59 +0100 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 =?iso-8859-1?Q?Vent=F4se?= an 218 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: (Andy Wingo's message of "Fri, 19 Feb 2010 14:30:42 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9999 Archived-At: Hello! (Sorry for the late & light review...) "Andy Wingo" writes: > diff --git a/libguile/fluids.h b/libguile/fluids.h > index 7aefd47..0d61fd2 100644 > --- a/libguile/fluids.h > +++ b/libguile/fluids.h > @@ -54,13 +54,8 @@ > grow. > */ >=20=20 > -/* The fastest way to acces/modify the value of a fluid. These macros > - do no error checking at all. The first argument is the index > - number of the fluid, obtained via SCM_FLUID_NUM, not the fluid > - itself. You must make sure that the fluid remains protected as > - long you use its number since numbers of unused fluids are reused > - eventually. > -*/ > +#define SCM_I_FLUID_P(x) (!SCM_IMP (x) && SCM_TYP7 (x) =3D=3D s= cm_tc7_fluid) How about renaming it to =E2=80=98SCM_FLUID_P=E2=80=99 and making it public? > +#define SCM_I_FLUID_NUM(x) ((size_t)SCM_CELL_WORD_1(x)) Could be in #ifdef BUILDING_LIBGUILE? > diff --git a/libguile/vm-engine.c b/libguile/vm-engine.c > index 75dd613..5d1e1d6 100644 > --- a/libguile/vm-engine.c > +++ b/libguile/vm-engine.c > @@ -47,6 +47,7 @@ VM_NAME (SCM vm, SCM program, SCM *argv, int nargs) > SCM *objects =3D NULL; /* constant objects */ > size_t object_count =3D 0; /* length of OBJECTS */ > SCM *stack_limit =3D vp->stack_limit; /* stack limit address */ > + SCM dynstate =3D SCM_I_CURRENT_THREAD->dynamic_state; Out of curiosity, what effect does this have on performance? > + ( fluid) > + ( fluid exp) At first sight =E2=80=98fluid-ref=E2=80=99 and =E2=80=98fluid-set=E2=80=99 = would seem more natural names to me. What do you think? Thanks, Ludo=E2=80=99.