From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] Move slow path out of 'scm_get_byte_or_eof' et al
Date: Wed, 03 Apr 2013 10:12:59 +0200 [thread overview]
Message-ID: <874nfot4l0.fsf@gnu.org> (raw)
In-Reply-To: 874nfo24zp.fsf@tines.lan
Mark H Weaver <mhw@netris.org> skribis:
> Fair enough. First of all, this patch reduces the size of the built
> libguile.so by about 42 kilobytes, and libguile.a by about 96 kilobytes.
>
> As for performance: the updated patches (attached below) slows things
> down by about one quarter of one percent on my machine. The specific
> benchmark I did was to call 'read-string' on an 11 megabyte ASCII text
> file, with the port-encoding set to UTF-8. In this case, all the reads
> are done using 'scm_get_byte_or_eof' (called from 'get_utf8_codepoint').
OK. Interesting.
> I've attached the new patches. Okay to push now?
Yes!
Thanks for the analysis,
Ludo’.
prev parent reply other threads:[~2013-04-03 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 9:59 [PATCH] Move slow path out of 'scm_get_byte_or_eof' et al Mark H Weaver
2013-04-02 12:43 ` Mike Gran
2013-04-02 15:59 ` Ludovic Courtès
2013-04-02 17:54 ` Mark H Weaver
2013-04-02 18:10 ` Mike Gran
2013-04-03 8:12 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nfot4l0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).