From: Andy Wingo <wingo@pobox.com>
To: Dmitry Bogatov <KAction@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH 1/2] Fix memory leak on `realloc' failure
Date: Tue, 22 Apr 2014 22:25:56 +0200 [thread overview]
Message-ID: <874n1lm7qj.fsf@pobox.com> (raw)
In-Reply-To: <20140412065951.GA2532@localhost.kaction.name> (Dmitry Bogatov's message of "Sat, 12 Apr 2014 10:59:51 +0400")
On Sat 12 Apr 2014 08:59, Dmitry Bogatov <KAction@gnu.org> writes:
> * Dmitry Bogatov <KAction@gnu.org> [2014-04-10 20:52:43+0400]
>> > > + {
>> > > + free (nargv);
>> > > return 0L;
>> > > + }
>> > > else
>> > > nargv[nargi++] = narg;
>> > I don't understand this. In both cases, free() will be called with an
>> > argument of 0, which does nothing.
>> My bad. It does not fix problem, that if realloc fails, it does not free
>> memory, but we blindly assign, losing pointer to previous memory
>> chunk.
>
> Attached new version. Please, take a look.
Applied, thanks. I altered the commit log; please take a look and
submit in that format in the future. The "magit" emacs mode makes it
easy to produce this format.
Cheers,
Andy
--
http://wingolog.org/
prev parent reply other threads:[~2014-04-22 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 5:37 [PATCH 1/2] Fix memory leak on `realloc' failure KAction
2014-04-10 5:37 ` [PATCH 2/2] Reduce scope of variables KAction
2014-04-10 16:36 ` [PATCH 1/2] Fix memory leak on `realloc' failure dsmich
2014-04-10 16:52 ` Dmitry Bogatov
2014-04-12 6:59 ` Dmitry Bogatov
2014-04-22 20:25 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n1lm7qj.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=KAction@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).