From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: David Pirotte <david@altosw.be>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: guile-lib - devel branch - unit-test 2 new APIs - 1 patch
Date: Sun, 15 Jan 2017 03:04:57 +0100 [thread overview]
Message-ID: <874m1113jq.fsf@ac.upc.edu> (raw)
In-Reply-To: <20161022230653.492af74b@capac> (David Pirotte's message of "Fri, 13 Jan 2017 23:31:34 -0200")
David Pirotte writes:
> Hello Guilers,
> Attached: 1 patch
> Please reivew, test ...: unless negative feedback, I should push it, merge to master
> and release Guile-Lib 0.2.5 within the next few days (*)
Nit pick: I don't know what's the coding convention in guile, but your use of
tabs is inconsistent within the patch and across the rest of the file.
Cheers,
Lluis
next prev parent reply other threads:[~2017-01-15 2:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 1:06 guile-lib - devel branch - 4 patches David Pirotte
2017-01-15 2:04 ` Lluís Vilanova [this message]
2017-01-15 19:55 ` guile-lib - devel branch - unit-test 2 new APIs - 1 patch David Pirotte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m1113jq.fsf@ac.upc.edu \
--to=vilanova@ac.upc.edu \
--cc=david@altosw.be \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).