Re: [PATCH 0/3] Add '-Wunused-module'

[Jan Nieuwenhuizen <janneke@gnu.org>]

Ludovic Courtès writes:

Hello,

> The new ‘-Wunused-module’ warning is enabled at ‘-W2’ only.  The main
> reason for not enabling it at ‘-W1’ is that in the case of modules used
> at macro-expansion time only, such as (srfi srfi-26), it cannot
> determine whether a module is definitely unused.  In this case, the
> compiler reports the module as “possibly unused”, and it is up to the
> programmer to check that claim.
[..]
> Thoughts?

The `possibly undefined' warnings about the srfi-9 gnu, srfi-26 and
curried-definition modules are a bit unfortunate, but easy to check.
It allowed me to trim quite some imports in Dezyne modules.
Very nice!

It seems that only re-exporting a (non-macro) variable from an otherwise
un used module gives a false positive `unused module' warning; it
doesn't even say `possibly unused module'.  Not a big problem, but can
anything be done about that?

Greetings,
Janneke

$ git diff --stat
 dzn/ast.scm               |  3 ---
 dzn/ast/display.scm       |  3 +--
 dzn/ast/equal.scm         |  5 +----
 dzn/ast/goops.scm         |  1 -
 dzn/ast/lookup.scm        |  1 -
 dzn/ast/normalize.scm     | 17 ++++++++---------
 dzn/ast/parse.scm         |  4 ----
 dzn/ast/wfc.scm           |  1 -
 dzn/code.scm              |  7 -------
 dzn/code/c++.scm          |  6 ------
 dzn/code/dot.scm          |  4 +---
 dzn/code/dzn.scm          |  7 -------
 dzn/code/json.scm         |  4 +---
 dzn/code/makreel.scm      |  6 +-----
 dzn/commands/code.scm     |  3 +--
 dzn/commands/graph.scm    |  3 +--
 dzn/commands/lts.scm      |  4 +---
 dzn/commands/parse.scm    |  4 ----
 dzn/commands/simulate.scm |  3 +--
 dzn/commands/traces.scm   |  4 +---
 dzn/commands/verify.scm   |  5 +----
 dzn/explore.scm           |  4 ----
 dzn/indent.scm            |  8 +-------
 dzn/lts.scm               |  3 +--
 dzn/parse/peg.scm         |  5 +----
 dzn/peg.scm               |  3 +--
 dzn/script.scm            |  4 +---
 dzn/simulate.scm          |  2 --
 dzn/templates.scm         |  4 +---
 dzn/verify/constraint.scm |  4 +---
 dzn/verify/pipeline.scm   |  2 --
 dzn/vm/compliance.scm     |  1 -
 dzn/vm/evaluate.scm       |  3 +--
 dzn/vm/report.scm         |  1 -
 dzn/vm/run.scm            |  4 +---
 dzn/vm/step.scm           |  2 --
 dzn/vm/util.scm           |  4 +---
 test/dzn/dzn.scm          |  6 +++---
 test/dzn/language.scm     | 11 ++++++-----
 test/dzn/normalize.scm    |  5 ++---
 test/dzn/silence.scm      |  3 +--
 41 files changed, 41 insertions(+), 133 deletions(-)

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com