From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: Re: ash rewrite Date: Thu, 10 Feb 2005 09:16:29 +1100 Message-ID: <873bw5xttu.fsf@zip.com.au> References: <87oefaqyiu.fsf@zip.com.au> <87zmyd5sn5.fsf@trouble.defaultvalue.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1107988933 9569 80.91.229.2 (9 Feb 2005 22:42:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 9 Feb 2005 22:42:13 +0000 (UTC) Cc: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Feb 09 23:42:12 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Cz0Wk-000610-J4 for guile-devel@m.gmane.org; Wed, 09 Feb 2005 23:41:42 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Cz0lM-0008M3-MC for guile-devel@m.gmane.org; Wed, 09 Feb 2005 17:56:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Cz0hM-0006us-SI for guile-devel@gnu.org; Wed, 09 Feb 2005 17:52:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Cz0hA-0006s3-5c for guile-devel@gnu.org; Wed, 09 Feb 2005 17:52:30 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Cz0h9-0006mW-Qz for guile-devel@gnu.org; Wed, 09 Feb 2005 17:52:27 -0500 Original-Received: from [61.8.0.84] (helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cz08X-0004fm-1Y for guile-devel@gnu.org; Wed, 09 Feb 2005 17:16:41 -0500 Original-Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j19MGZA6029610; Thu, 10 Feb 2005 09:16:35 +1100 Original-Received: from localhost (ppp25B5.dyn.pacific.net.au [61.8.37.181]) by mailproxy1.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j19MGYTu005616; Thu, 10 Feb 2005 09:16:34 +1100 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1Cz08L-0001KJ-00; Thu, 10 Feb 2005 09:16:29 +1100 Original-To: Rob Browning Mail-Copies-To: never In-Reply-To: <87zmyd5sn5.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Wed, 09 Feb 2005 15:29:34 -0600") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org X-MailScanner-To: guile-devel@m.gmane.org Xref: main.gmane.org gmane.lisp.guile.devel:4765 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:4765 Rob Browning writes: > > Hmm I noticed that at least on my machine, make check fails with > current CVS. Thanks, I'll remove those. > ERROR: fractions.test: fractions: (eqv? (ash 1/2 0) 1/2) - arguments: ((wrong-type-arg "ash" "Wrong type argument in position ~A: ~S" (1 1/2) (1/2))) > ERROR: fractions.test: fractions: (eqv? (ash 1/2 1) 1) - arguments: ((wrong-type-arg "ash" "Wrong type argument in position ~A: ~S" (1 1/2) (1/2))) ash had worked to left shift a fraction, because it was done with a multiply. It never right shifted a fraction. My change unified that, by making neither left nor right work :-). There'd be nothing wrong with having ash support fractions, or inexacts for that matter. But it seemed to me a bit of a slippery slope. You might start thinking other of the "Bitwise Operations" functions should also work on those. Like logbit? or logand. They'd have sensible definitions on fractions and inexacts, but it'd be a bit like hard work implementing it. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel