From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marius Vollmer Newsgroups: gmane.lisp.guile.devel Subject: Re: make-uniform-vector bit vector versus array-set! Date: Sun, 26 Feb 2006 12:00:50 +0200 Message-ID: <873bi6xwvh.fsf@zagadka.de> References: <87zmkfuq0k.fsf@zip.com.au> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1140976492 26582 80.91.229.2 (26 Feb 2006 17:54:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 26 Feb 2006 17:54:52 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Feb 26 18:54:50 2006 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FDQ6Y-0008Lz-M5 for guile-devel@m.gmane.org; Sun, 26 Feb 2006 18:54:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FDQ6c-0007zD-Rc for guile-devel@m.gmane.org; Sun, 26 Feb 2006 12:54:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FDIiW-0001zp-TC for guile-devel@gnu.org; Sun, 26 Feb 2006 05:01:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FDIiJ-0001ub-Ip for guile-devel@gnu.org; Sun, 26 Feb 2006 05:01:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FDIiG-0001uD-96 for guile-devel@gnu.org; Sun, 26 Feb 2006 05:01:13 -0500 Original-Received: from [213.243.153.35] (helo=smtp2.pp.htv.fi) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FDIii-0002VD-QA for guile-devel@gnu.org; Sun, 26 Feb 2006 05:01:41 -0500 Original-Received: from zagadka.ping.de (cs181072157.pp.htv.fi [82.181.72.157]) by smtp2.pp.htv.fi (Postfix) with SMTP id D6429296B8C for ; Sun, 26 Feb 2006 12:01:04 +0200 (EET) Original-Received: (qmail 28014 invoked by uid 1000); 26 Feb 2006 12:00:50 +0200 Original-To: guile-devel@gnu.org In-Reply-To: <87zmkfuq0k.fsf@zip.com.au> (Kevin Ryde's message of "Sun, 26 Feb 2006 07:44:59 +1100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:5747 Archived-At: Kevin Ryde writes: > I don't understand all that stuff, but I got some joy from this > change. Can someone (Marius?) confirm or deny? > > * unif.c (bitvector_set): Should be h->writable_elements not > h->elements, the latter results in a segv in array-set! on a bit > vector. This is the right fix. Thanks! Readers like bitvector_ref should use h->elements, and setters like bitvector_set should use h->writable_elements. Those two pointers are set up by memoize_ref and memoize_set, respectively. -- GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405 _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel