unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Marius Vollmer <mvo@zagadka.de>
Subject: Re: make-uniform-vector bit vector versus array-set!
Date: Sun, 26 Feb 2006 12:00:50 +0200	[thread overview]
Message-ID: <873bi6xwvh.fsf@zagadka.de> (raw)
In-Reply-To: <87zmkfuq0k.fsf@zip.com.au> (Kevin Ryde's message of "Sun, 26 Feb 2006 07:44:59 +1100")

Kevin Ryde <user42@zip.com.au> writes:

> I don't understand all that stuff, but I got some joy from this
> change.  Can someone (Marius?) confirm or deny?
>
>         * unif.c (bitvector_set): Should be h->writable_elements not
>         h->elements, the latter results in a segv in array-set! on a bit
>         vector.

This is the right fix.  Thanks!

Readers like bitvector_ref should use h->elements, and setters like
bitvector_set should use h->writable_elements.  Those two pointers are
set up by memoize_ref and memoize_set, respectively.

-- 
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3  331E FAF8 226A D5D4 E405


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel


      reply	other threads:[~2006-02-26 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-25 20:44 make-uniform-vector bit vector versus array-set! Kevin Ryde
2006-02-26 10:00 ` Marius Vollmer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873bi6xwvh.fsf@zagadka.de \
    --to=mvo@zagadka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).