From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: the new gc asserts in master Date: Wed, 27 Aug 2008 09:43:57 +0200 Message-ID: <873akq3nsy.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1219823069 6548 80.91.229.12 (27 Aug 2008 07:44:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Aug 2008 07:44:29 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Aug 27 09:45:23 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYFiU-0003Py-EU for guile-devel@m.gmane.org; Wed, 27 Aug 2008 09:45:22 +0200 Original-Received: from localhost ([127.0.0.1]:36924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYFhW-0004JM-A0 for guile-devel@m.gmane.org; Wed, 27 Aug 2008 03:44:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYFhP-0004JA-Ry for guile-devel@gnu.org; Wed, 27 Aug 2008 03:44:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYFhO-0004Im-5e for guile-devel@gnu.org; Wed, 27 Aug 2008 03:44:15 -0400 Original-Received: from [199.232.76.173] (port=50365 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYFhN-0004Ij-Ux for guile-devel@gnu.org; Wed, 27 Aug 2008 03:44:14 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:53366 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KYFhN-0003F9-CI for guile-devel@gnu.org; Wed, 27 Aug 2008 03:44:13 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KYFhI-0000FX-LN for guile-devel@gnu.org; Wed, 27 Aug 2008 07:44:08 +0000 Original-Received: from 193.50.110.127 ([193.50.110.127]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Aug 2008 07:44:08 +0000 Original-Received: from ludo by 193.50.110.127 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Aug 2008 07:44:08 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 50 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 193.50.110.127 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 Fructidor an 216 de la =?iso-8859-1?Q?R=E9volutio?= =?iso-8859-1?Q?n?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i686-pc-linux-gnu User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) Cancel-Lock: sha1:zVF7eOtKTCV4YUYwBZu4LITtgmE= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7512 Archived-At: Hi, Han-Wen Nienhuys writes: > I am pushing a fix for this to master. Will you care to post and discuss your patches before pushing them? This is all the more important that the patches don't seem to have any relation with the problem at hand: f85ea2a85fcdd051f432964806f044c0301d0945 Merge branch 'master' of git://git.sv.gnu.org/guile into nits 487b9dec2ea6b88ddbc6fbd17f445ddb197aebc5 Only sanity check numbers if SCM_DEBUG_CELL_ACCESSES is unset. 80237dcc7783b4d94ecf1d987deb9306d61735a0 Set SRCPROP{PLIST,COPY} through a macro, so SCM_DEBUG_CELL_ACCESSES compiles. Can you please describe them and add ChangeLog entries (yes, we still use that)? In addition, they don't fix anything on x86-64: $ ./pre-inst-guile lt-guile: gc.c:610: scm_i_gc: Assertion `scm_i_gc_sweep_stats.collected + scm_cells_allocated == scm_i_gc_sweep_stats.swept' failed. Aborted (core dumped) Do you think you can come up with a fix within the next few days? Otherwise, I'm inclined to revert the offending commits in `master' and wait for a signal from you (i.e., a patch or merge request posted to the mailing list, *not* a commit on `master'). It would make it easier for us to play with `master' in the meantime. Besides, avoid pushing from an non-up-to-date repo: this yields to automatic merges like the one above, which is annoying as it makes history harder to follow. Better pull first, then merge your changes, then push. >> even the lazy smob case I wrote about here: >> >> http://thread.gmane.org/gmane.lisp.guile.user/6372 > > I would classify the use of mark bits outside of the mark phase as outside > of the defined API. If you want to have weak pointer semantics, use > a weak hashtable, or implement reference counting on the C side. That's a reasonable argument, but it's something we should not change without discussing it first. For instance, it may be important to study why Guile-GNOME had to resort to this, and how it could avoid it, instead of just gratuitously breaking it. Thanks, Ludo'.