Re: [PATCH] Add implementation of SRFI 38

[ludo@gnu.org (Ludovic Courtès)]

Hi Andreas!

Andreas Rottmann <a.rottmann@gmx.at> writes:

> +++ b/module/srfi/srfi-38.scm
> @@ -0,0 +1,203 @@
> +;; Copyright (C) Andreas Rottmann 2010.

Should be FSF.  :-)

> +;; Copyright (C) Ray Dillinger 2003. All Rights Reserved.

Alex Shinn should be mentioned, though without “copyright” since he’s
not a copyright holder strictly speaking.

> +;; Permission is hereby granted, free of charge, to any person obtaining
> +;; a copy of this software and associated documentation files (the
> +;; "Software"), to deal in the Software without restriction, including
> +;; without limitation the rights to use, copy, modify, merge, publish,
> +;; distribute, sublicense, and/or sell copies of the Software, and to
> +;; permit persons to whom the Software is furnished to do so, subject to
> +;; the following conditions:
> +
> +;; The above copyright notice and this permission notice shall be
> +;; included in all copies or substantial portions of the Software.

I wonder what “sublicense” above mean given that the permission notice
must remain.  For instance, we could distribute it under the LGPL but
the original license would still be applicable, right?

> +++ b/test-suite/tests/srfi-38.test
> @@ -0,0 +1,50 @@
> +;; -*- scheme -*-
> +
> +(define-module (test-srfi-38)

Please add the copyright/license header.

Thanks,
Ludo’.