unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: Mark Harig <idirectscm@aim.com>
Cc: guile-devel@gnu.org
Subject: Re: Patch: New section "Invoking Guile" for chapter "Programming in Scheme"
Date: Thu, 30 Jun 2011 13:23:53 +0200	[thread overview]
Message-ID: <8739irbm0m.fsf@pobox.com> (raw)
In-Reply-To: <8CDD19915ED74FC-D20-21138@webmail-d017.sysops.aol.com> (Mark Harig's message of "Mon, 25 Apr 2011 15:49:55 -0400")

Hi Mark,

On Mon 25 Apr 2011 21:49, Mark Harig <idirectscm@aim.com> writes:

>> 
>> > On Sun, Apr 24, 2011 at 04:33:44PM +0200, Andy Wingo wrote:
>> >> your patches should be "atomic"
>> >
>> > "3. No patch introduces a regression: after applying any
>> > initial part of the series, the resulting project still
>> > compiles and works, and has no bugs that it didn’t have
>> > before."
>> 
>> Right, at the end of applying all of your patches, I'm sure that's the
>> case; however the first patch adds an @include without adding the
>> appropriate file, so applying just the first patch without the following
>> two would yield a project that doesn't compile.  I just meant that you
>> need to squish the first two or three of them together.  I can do that
>> when I apply them, though.

I went ahead and did this.  Your commit logs were good but in the future
please provide an initial description line, and wrap the change
descriptions to 72 characters.  See any of the Guile commit messages for
examples.

> In order to expedite this change, I am attaching the three updated patches.

I'm sorry that our back-and-forth distracted us from actually making
forward progress.  I have applied your patches, and the changes should
be in 2.0.2's manual.

Thanks again,

Andy
-- 
http://wingolog.org/



      parent reply	other threads:[~2011-06-30 11:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-23 19:46 Patch: New section "Invoking Guile" for chapter "Programming in Scheme" Mark Harig
2011-04-24 14:33 ` Andy Wingo
2011-04-24 20:36   ` Mark Harig
2011-04-24 21:00     ` Andy Wingo
2011-04-24 21:58       ` Mark Harig
2011-04-25  8:01         ` Andy Wingo
2011-04-24 22:09       ` David Pirotte
2011-04-24 22:43         ` Indexing Scheme and C identifiers separately Mark Harig
2011-04-25  1:18           ` Noah Lavine
2011-04-25 16:16           ` David Pirotte
2011-05-20 22:53             ` Neil Jerram
2011-04-25 19:49       ` Patch: New section "Invoking Guile" for chapter "Programming in Scheme" Mark Harig
2011-04-26 18:07         ` Neil Jerram
2011-04-26 21:01           ` Ludovic Courtès
2011-04-27  9:40             ` Andy Wingo
2011-04-27 10:23               ` Ludovic Courtès
2011-04-27 19:29                 ` Neil Jerram
2011-04-27 16:54           ` Mark Harig
2011-04-27 19:40             ` Neil Jerram
2011-06-30 11:23         ` Andy Wingo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739irbm0m.fsf@pobox.com \
    --to=wingo@pobox.com \
    --cc=guile-devel@gnu.org \
    --cc=idirectscm@aim.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).