From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Newsgroups: gmane.lisp.guile.devel Subject: Re: bug#56867: [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7. Date: Wed, 03 Aug 2022 17:57:44 +0200 Message-ID: <8735eds4jr.fsf@gnu.org> References: <20220801090749.11655-1-ludo@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2961"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) Cc: guile-devel@gnu.org To: 56867-done@debbugs.gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Aug 03 17:58:07 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJGl5-0000c0-4g for guile-devel@m.gmane-mx.org; Wed, 03 Aug 2022 17:58:07 +0200 Original-Received: from localhost ([::1]:52388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJGl3-0002Ec-Ta for guile-devel@m.gmane-mx.org; Wed, 03 Aug 2022 11:58:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGkn-0002EN-2r for guile-devel@gnu.org; Wed, 03 Aug 2022 11:57:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGkm-0003zA-Py; Wed, 03 Aug 2022 11:57:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AmCAckqpn7x6am8j3opihJE0KLOmiMKLJ5Y7+WCaL70=; b=R7jvl9G8FgLclKI9rpph LciU8lHB4F9MoufVXPFijN88OrSn4feMo7DfgNtKm4i5+n0nrniYE5ECQVJHTssCyKGyK86ZL17K2 PANz1f5gfBJVACAh81Qlt0SNu3RZ9bCM5boZvXpOFEP0x2e0X+gQfeZKXhm+sfKbKkOWVAYr4Juuq 9ziNWQ/+V14GejWjMwuYLt2o+0VfKE7fOshnkeQQPbaMMKOOCyReKvXVnjcLxaxrtxJbdzPUMUZyX sV6fQYrRqf2JPNNFYGVP/vNFJDIhd4q2KIYFJ5Z1U5X/P5GWJ4X8RQyeibZL3OHVtIHnq0IOc6uoL eyCMIDhnCf8VNg==; Original-Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:58690 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGkm-0004Al-DD; Wed, 03 Aug 2022 11:57:48 -0400 In-Reply-To: <20220801090749.11655-1-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Mon, 1 Aug 2022 11:07:49 +0200") X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21291 Archived-At: Ludovic Court=C3=A8s skribis: > The custom input/output port wrapping the TLS session record port would > introduce overhead, and it would also prevent its uses in a non-blocking > context--e.g., with Fibers. The port close mechanism added in GnuTLS > 3.7.7 allows us to get rid of that wrapper. > > * guix/build/download.scm (wrap-record-port-for-gnutls<3.7.7): New > procedure, with code formerly in 'tls-wrap'. > (tls-wrap): Check for 'set-session-record-port-close!' and use it when > available; otherwise call 'wrap-record-port-for-gnutls<3.7.7'. > --- > guix/build/download.scm | 102 +++++++++++++++++++++------------------- > 1 file changed, 54 insertions(+), 48 deletions(-) Pushed as Guix commit dd573ceea73295c7a872088ecd91e5f0fd74bf2b. Ludo=E2=80=99.